Bug 236970 - WISH: crop could automatically use image dimension (e.g. 3:4 or 4:3)
Summary: WISH: crop could automatically use image dimension (e.g. 3:4 or 4:3)
Status: RESOLVED FIXED
Alias: None
Product: gwenview
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Ubuntu Linux
: NOR wishlist
Target Milestone: ---
Assignee: Gwenview Bugs
URL:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2010-05-09 12:21 UTC by Ari
Modified: 2018-03-22 11:05 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ari 2010-05-09 12:21:07 UTC
Version:           Version 2.4.2 Using KDE Development Platform 4.4.2 (KDE 4.4.2) (using KDE 4.4.2)
OS:                Linux
Installed from:    Ubuntu Packages

When using gwenview to crop images, it uses free selection by default. For every image, one must:

(1) Select from menu: Edit->Crop
(2) check selection: Select advanced settings
(3) choose manually the correct ratio
(4) do the cropping
(5) save

There could be a handy shortcut and a setting "use automatically determined ratio when cropping images", with which the cropping would be:

(1) use shortcut, e.g. Alt-C
(2) crop image with automatically determined ratio, say 3:4
(3) save

When handling hundreds of images, this greatly improves ones mental health. ;-)
Comment 1 Vladimir Brik 2012-02-22 01:34:45 UTC
By default the cropping tool should maintain the image's aspect ratio.

Improving framing by cropping right after images have been taken is a very common operation and may need to be done to hundreds of images at a time (if nothing else, just to see how they would look cropped).
Comment 2 emmanuel.manchester314 2012-08-22 22:32:08 UTC
I agree.
crop should automatically use current image dimension ratio (3/2, 2/3 etc.) as firat option for croping
Then advanced menu would allow to choose free crop or another ratio

Thanks
Comment 3 Huon 2018-03-10 05:46:18 UTC
Revision for this: https://phabricator.kde.org/D11202

As mentioned in revision, it might be a bad idea to change the default behaviour. Other ideas are to make the default a config option, or have the crop tool remember the last chosen ratio.
Comment 4 Huon 2018-03-10 05:46:39 UTC
Revision for this: https://phabricator.kde.org/D11202

As mentioned in revision, it might be a bad idea to change the default behaviour. Other ideas are to make the default a config option, or have the crop tool remember the last chosen ratio.
Comment 5 Huon 2018-03-22 11:05:47 UTC
Git commit 576cfa68ba01b7997c4e3e401b9b502ce1d6da04 by Huon Imberger.
Committed on 22/03/2018 at 11:05.
Pushed by huoni into branch 'Applications/18.04'.

Add ability to constrain crop tool to current image ratio

Summary:
The crop tool was lacking the ability to choose the ratio of the current image.
This patch adds:
  - Checkbox in {nav Normal} to toggle between no restriction (default),
  and restrict to the current image ratio
  - "Current Image" item to the Ratio combobox in {nav Advanced}
  - "Unrestricted" item to the Ratio combobox in {nav Advanced}
  (default, functionally no change from before)
  - Clear button to the Ratio combobox in {nav Advanced}, to help make
  it clear the user can enter a custom ratio

Test Plan:
  # {nav Image} view > enable crop tool (e.g. by using {key shift}+{key
  c}
  # Ensure ratio restrictions work in both {nav Normal} and {nav Advanced}

The ratio settings in {nav Normal} and {nav Advanced} are independant of
one another, in prep for future patch which will have these remember the
chosen setting.

Reviewers: #gwenview, rkflx

Reviewed By: #gwenview, rkflx

Subscribers: muhlenpfordt

Differential Revision: https://phabricator.kde.org/D11202

M  +3    -0    lib/crop/croptool.cpp
M  +68   -33   lib/crop/cropwidget.cpp
M  +4    -1    lib/crop/cropwidget.h
M  +8    -1    lib/crop/cropwidget.ui
M  +1    -0    lib/documentview/rasterimageview.cpp
M  +1    -0    lib/documentview/rasterimageview.h

https://commits.kde.org/gwenview/576cfa68ba01b7997c4e3e401b9b502ce1d6da04