Version: (using Devel) Installed from: Compiled sources filing this here so kevin won't forget ;) when patches are badly formed, kompare silently ignores what it thinks are comments. a patch like http://ktown.kde.org/~fredrik/folderview.diff shows up like http://chani.ca/sshots/komparefail.png the user should be warned when there's stuff in the file that's not visible in the UI (imho there should be an easy way to view these 'comments' too, but I don't care enough to write a patch for that ;)
As discussed on IRC, patch errors out on this with "patch: **** malformed patch at line 15: …", I think this is the behavior we'll want to match more or less. What I suggested on IRC is that we still display what we can, but pop up a KMessageBox complaining about the malformed patch.
I'm taking care of this now, given the impending message freeze.
SVN commit 1128360 by kkofler: Kompare: Detect malformed diffs and display an error message to the user in that case. Still display what we can display, but tell the user that some lines will be missing. Tested on Fedora 12, kdelibs 4.4.2. BUG: 235503 M +8 -1 komparemodellist.cpp M +3 -2 parser.cpp M +2 -1 parser.h M +35 -8 parserbase.cpp M +4 -1 parserbase.h WebSVN link: http://websvn.kde.org/?view=rev&revision=1128360