Bug 234545 - Red eye correction tool is missing from image editor
Summary: Red eye correction tool is missing from image editor
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Faces-RedEyes (show other bugs)
Version: 1.2.0
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-16 17:36 UTC by Andreas Tiemeyer
Modified: 2022-01-14 03:43 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 1.3.0
Sentry Crash Report:


Attachments
corrected name for redeye plugin (712 bytes, patch)
2010-04-17 02:03 UTC, Andreas Tiemeyer
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Tiemeyer 2010-04-16 17:36:12 UTC
Version:           1.2.0 (using KDE 4.4.2)
OS:                Linux
Installed from:    Archlinux Packages

Digikam image editor should have a 'red eye correction' tool in the 'enhance' menu according to the documentation.
This menu entry has disappeared.
Comment 1 caulier.gilles 2010-04-16 18:33:02 UTC
Not reproducible there. Sound like a packaging issue.

please start digiKam from a console and post there all debug messages. note : install digikam-debug package before...

Gilles Caulier
Comment 2 Andreas Tiemeyer 2010-04-17 02:03:41 UTC
Created attachment 42832 [details]
corrected name for redeye plugin
Comment 3 Andreas Tiemeyer 2010-04-17 02:08:04 UTC
Comment on attachment 42832 [details]
corrected name for redeye plugin

The problem seems to be that the name of the redeye plugin is not the same in the _rc.ui file and the c++ code.

However: if this is the root cause, the bug should be reproducible every time on the released sources. So I don't understand how it counld not be reproduced.
Comment 4 caulier.gilles 2010-04-17 11:15:10 UTC
This problem will must be fixed in 1.3.0 (code from svn trunk). I factored image plugins to speed up startup.

Can you checkout code from svn trunk and confirm please ?

Gilles Caulier
Comment 5 SanskritFritz 2010-04-17 15:18:59 UTC
I can confirm that the patch works, I recompiled digikam 1.2 with the patch applied, and redeye correction is back. Thank you.
Comment 6 Andreas Tiemeyer 2010-04-17 18:03:02 UTC
(In reply to comment #4)
> 
> Can you checkout code from svn trunk and confirm please ?
> 
> Gilles Caulier
>

That pulls in too many dependencies - I'd have to rebuild kdegraphics from svn as well according to the package information of my distribution, which I usually trust. I don't think it's worth it - this isn't a bug that depends on the environment. If it works for you on the trunk sources, it will work for me.
Comment 7 SanskritFritz 2010-04-19 10:43:36 UTC
The functionality is still there, the item is just missing from the Enhance menu. Instead of recompiling and applying a patch you can try adding a custom "Red Eye" button to the toolbar. 
http://bbs.archlinux.org/viewtopic.php?pid=744981#p744981
Comment 8 sean 2010-04-24 15:52:43 UTC
I'm using digikam and kipi-plugins from svn today: At revision 1118351.

There's no red eye correction tool in the Enhance menu.

sean
Comment 9 sean 2010-04-24 16:03:35 UTC
Just tried the steps from http://bbs.archlinux.org/viewtopic.php?pid=744981#p744981.

That had no effect. In fact, it didn't change the Enhance drop down menu for any item if I changed it.
Comment 10 SanskritFritz 2010-04-24 21:15:40 UTC
sean, if you read it more carefully, you will see it changes the toolbar and not the menu.
Comment 11 sean 2010-04-24 21:26:15 UTC
I'm in Image Editor. I see 3 toolbars:

Top:  File Edit View Color etc
Just below Top:  First Back Forward etc
Bottom: <filename>  No selection <w x h> etc

I don't see Red Eye anywhere. Am I looking in the wrong place? 

sean
Comment 12 SanskritFritz 2010-04-24 21:31:17 UTC
Right click on the toolbar / Configure toolbars / Toolbar: digikamimageplugin_enhance / highlight Red Eye in the list below / Click the right arrow to transfer it to the right side / Ok.
Comment 13 caulier.gilles 2010-04-25 07:27:29 UTC
SVN commit 1118552 by cgilles:

use right name for Red eyes tool action
BUGS: 234545


 M  +2 -2      digikamimageplugin_enhance_ui.rc  
 M  +1 -1      imageplugin_enhance.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1118552