Bug 234385 - [PATCH] Option to disable unread article display in tray icon
Summary: [PATCH] Option to disable unread article display in tray icon
Status: RESOLVED FIXED
Alias: None
Product: akregator
Classification: Applications
Component: general (show other bugs)
Version: 1.5.3
Platform: unspecified Linux
: NOR wishlist
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-14 22:10 UTC by Simon80
Modified: 2010-07-28 09:45 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
patch to fix this bug (3.53 KB, patch)
2010-04-30 21:09 UTC, Simon80
Details
updated patch (4.03 KB, patch)
2010-06-15 09:03 UTC, Simon80
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Simon80 2010-04-14 22:10:27 UTC
Version:           1.5.3 (using 4.3.4 (KDE 4.3.4), Debian packages)
Compiler:          cc
OS:                Linux (x86_64) release 2.6.32-3-amd64

I like Akregator, but having the number of unread items displayed in the tray makes it hard to resist reading new articles as they come in, rather than whenever I decide I need a break. At the same time, I don't want to close Akregator altogether, to ensure that I don't miss items on certain feeds that only expose the last e.g. 48 hours of items.

I propose that an option be added under the "Show Tray Icon" option, "Display the number of unread items", which would be enabled by default.
Comment 1 Simon80 2010-04-30 21:09:51 UTC
Created attachment 43128 [details]
patch to fix this bug

I made a patch for the akregator in Debian testing, then ported it to svn. However, I didn't build and test the svn version of the patch.

I'd appreciate it if someone would review it, apply, build, make sure at least one article is unread, disable the unread article count in general settings, hit apply, verify that the unread article count disappears, perhaps test the reverse operation, and then commit this. The tray icon tooltip should be unaffected.
Comment 2 Simon80 2010-06-15 09:03:19 UTC
Created attachment 48024 [details]
updated patch

I accidentally omitted a signal connection from the UI file in the process of porting this patch to trunk. This updated patch has been tested directly, and  should work as intended.
Comment 3 Frank Osterfeld 2010-07-28 09:45:39 UTC
SVN commit 1155932 by osterfeld:

Allow disabling Akregator's tray icon unread article count

"The unread article count in Akregator's tray icon is useful, but can be
very distracting. A checkbox is provided to offer the choice of
disabling the unread article count, instead showing the default icon at
all times."

Patch by Simon Ruggier

FEATURE:234385

 M  +51 -1     configuration/settings_general.ui  
 M  +5 -0      interfaces/akregator.kcfg  
 M  +2 -4      src/trayicon.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1155932