Bug 234291 - no underscore w/ font "Bitstream Vera Sans Mono 11 pt"
Summary: no underscore w/ font "Bitstream Vera Sans Mono 11 pt"
Status: RESOLVED FIXED
Alias: None
Product: kompare
Classification: Applications
Component: general (show other bugs)
Version: 4.0.0
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Kompare developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-13 22:17 UTC by Toralf Förster
Modified: 2010-12-21 00:27 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.5.5


Attachments
No underscores in kwrite editor, but in a search box (12.33 KB, image/png)
2010-04-15 19:38 UTC, Sven Wehner
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Toralf Förster 2010-04-13 22:17:40 UTC
Version:           4.0.0 (using 4.4.2 (KDE 4.4.2), Gentoo)
Compiler:          i686-pc-linux-gnu-gcc
OS:                Linux (i686) release 2.6.34-rc4

When I change it to the size of 12 points or to 10 points, then the underscore is visible.
Comment 1 Sven Wehner 2010-04-15 19:35:43 UTC
I have a similar problem in kwrite, when I use "Sans Serif" with 10 points (9 pt and 11 pt work for me).

I also checked if the letter exists using kcharselect, setting font and size accordingly. And it seems to work properly.
In the Fonts Control Module I can select the general font, which is "Sans Serif" with 10 pt as well, and change the test text to include an underscore, which works fine as well.

Thus I think this is a more general problem.

I am using 96 dpi and "Sans Serif" is an alias for "Bitstream Vera Sans".
Comment 2 Sven Wehner 2010-04-15 19:38:31 UTC
Created attachment 42805 [details]
No underscores in kwrite editor, but in a search box

Here you can see the error in kwrite: The editor doesn't show the underscores (top line), while the search box does (using Ctrl+F while marking the string).
Comment 3 Sven Wehner 2010-04-15 20:00:25 UTC
Strange... I played around with the fonts... and I can't reproduce this error.

Could this be one of the many "I just copied my old kde-3/-4.X configuration folder to the kde-4.4 one"-bugs?

@Toralf, could you please try to set, many different fonts and then change back to your original one?
Comment 4 Toralf Förster 2010-04-15 20:40:48 UTC
I experience this behaviour only in kompare with "Bitstream Vera Sans Mono" and 11 points.

The same font works fine in kate and kwrite.

Changing the font to Courier is ok, but changing it back and the issue is still there.
Comment 5 Toralf Förster 2010-04-15 20:42:28 UTC
Well, issue happens for all "Bitstream Vera" fonts 11 point under Kompare.
Comment 6 esigra 2010-09-12 21:25:48 UTC
I have no underscores in Kompare 4.0.0 (KDE 4.5.1) with Andale Mono 10 and Bitstream Vera Sans Mono 11. Other sizes seem to work though.
Comment 7 esigra 2010-09-12 21:26:30 UTC
*** This bug has been confirmed by popular vote. ***
Comment 8 Christoph Feck 2010-11-29 02:10:06 UTC
SVN commit 1201883 by cfeck:

Fix cropped underscores

When rendering a text with multiple lines, it is usually
recommended to use lineSpacing() instead of height().

But the KompareListView renders each line individually with
a background rect that will overwrite any overhanging pixels
from the previous line. So use height() instead.

BUG: 234291
FIXED-IN: 4.6.0


 M  +3 -3      komparelistview.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1201883
Comment 9 Kevin Kofler 2010-11-29 02:20:16 UTC
Thanks for fixing this!

Unfortunately, it looks like we just missed 4.5.4 with this fix. :-( I'll backport this to 4.5.5 once the tagging freeze is lifted.
Comment 10 Christoph Feck 2010-11-29 03:34:10 UTC
If you are going to backport, please include r1201885.
Comment 11 Toralf Förster 2010-11-29 13:59:15 UTC
(In reply to comment #10)
> If you are going to backport, please include r1201885.

I backported both revs to 4.4.5 at my almost stable Gentoo system runnign KDE 4.4.5. KOmpare now works well, on the command line however I get now a lot of lines like :

...
load glyph failed err=6 face=0x89ff6d8, glyph=640
QFontEngine: Glyph neither outline nor bitmap format=0
...
Comment 12 Christoph Feck 2010-11-30 01:30:33 UTC
Toralf, this is bug 251016 and not related.
Comment 13 Kevin Kofler 2010-12-21 00:24:35 UTC
SVN commit 1208199 by kkofler:

Kompare:

* Fix cropped underscores

When rendering a text with multiple lines, it is usually
recommended to use lineSpacing() instead of height().

But the KompareListView renders each line individually with
a background rect that will overwrite any overhanging pixels
from the previous line. So use height() instead.

* Adapt KompareSplitter to listview line height change

Backport revisions 1201883 and 1201885 by cfeck from trunk to fix #234291 for 4.5.5.

CCBUG: 234291

 M  +3 -3      komparelistview.cpp  
 M  +3 -3      komparesplitter.cpp  
 M  +1 -1      komparesplitter.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1208199