Bug 234215 - QIF Import Filter Issues
Summary: QIF Import Filter Issues
Status: RESOLVED FIXED
Alias: None
Product: kmymoney
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: KMyMoney Devel Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-13 02:37 UTC by allan
Modified: 2010-06-01 09:43 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
import wizard (45.73 KB, image/png)
2010-05-09 14:18 UTC, allan
Details

Note You need to log in before you can comment on or make changes to this bug.
Description allan 2010-04-13 02:37:52 UTC
Version:           3.97.2 (using KDE 4.3.5)
OS:                Linux
Installed from:    Compiled From Sources

I have a csv import filter which appears to work correctly in 1.02, but when using it on v3.97.2, initially I had some small problems.

The file was not getting imported, and I looked at the profile wizard.  The 1.02 version has only two tabs - general and filter, where the 3.97.2 version has two additional tabs, including one for the date.  My filter uses '/' as the field separator and relies on KMM to understand this.  However, thinking the date format might be the cause, I found that on setting an appropriate value, this parameter appeared not to be retained, so did a bit of debugging.

I put debug statements in mymoneyqifreader.cpp, lines 296 and 315.  Line 296 showed the data sent to the filter and 315 the received data.  In between, there were varying numbers of spurious characters.  Another debug in line 299 also showed these characters.  Nevertheless, line 315 always seemed to show the correct filtered data.  Switching backwards and forwards between files and formats while debugging, somewhere along the way my import problem disappeared!

So,
a) query re tabs and date format settings.
b) possibly harmless spurious characters appearing.
And finally,
c) the profile wizard default size, for me, is too small and has to be resized each time to show the two bottom combo-boxes.
Comment 1 Alvaro Soliverez 2010-05-09 02:53:17 UTC
can you post a screenshot of the profile wizard, to pinpoint what to fix?
Comment 2 allan 2010-05-09 14:18:14 UTC
Created attachment 43398 [details]
import wizard
Comment 3 allan 2010-05-09 14:19:00 UTC
(In reply to comment #1)
> can you post a screenshot of the profile wizard, to pinpoint what to fix?

Here's a shot of the import wizard opening screen as I see it.
Comment 4 allan 2010-05-10 11:36:22 UTC
I've just loaded KMM from svn on a new install of Kubuntu 10.04, and the qif import wizard is OK there.

So I went back to my openSuse and after finding resizing didn't keep its settings, reducing the font size from 9 to 8 sorts out the wizard appearance for me.

I'll not close the bug in case you think anything else is needed.
Comment 5 Alvaro Soliverez 2010-05-10 12:12:18 UTC
Can someone else confirm the resize problem?

How about the other issues? Are they solved yet?
Comment 6 David Houlden 2010-05-10 12:37:22 UTC
(In reply to comment #5)
> Can someone else confirm the resize problem?
> 
Yes, I am getting exactly the same problem with the import option boxes being too small in the QIF import dialog.
Comment 7 allan 2010-05-10 13:44:55 UTC
(In reply to comment #5)
> Can someone else confirm the resize problem?
> 
> How about the other issues? Are they solved yet?

The qifimporter profile wizard still has the same four tabs that v0.9x used to have.  I think the Date tab could be misleading for, as I understand it, the qifimporter now is able better to determine the imported date format, and to ask the user to resolve any possible ambiguity.  So, I would say that that tab should definiteky be removed.  V1 no longer has the amount tab, either.

Perhaps Thomas should advise on what, if anything, else needs doing.

The other issue only showed when I was debugging.  There might be an issue still there, but it didn't seem to affect the outcome.
Comment 8 Thomas Baumgart 2010-05-10 14:44:34 UTC
I am about to bring back those tabs even in the 1.0 version because the data provided on them is required for the exporter.

BTW, it's not the 'QIF importer profile' but the 'QIF profile' which is good for import and export operations.
Comment 9 allan 2010-05-10 17:32:12 UTC
(In reply to comment #8)
> I am about to bring back those tabs even in the 1.0 version because the data
> provided on them is required for the exporter.
> 
> BTW, it's not the 'QIF importer profile' but the 'QIF profile' which is good
> for import and export operations.

So will the date format setting be just for export purposes?  Otherwise, how will it tie in with the 'new' intelligent detection?

As it is at the moment, one can choose a date format on that tab, but the setting appears not to be retained.
Comment 10 Thomas Baumgart 2010-05-10 20:29:21 UTC
The internal variables are overridden by the automatic detection of the importer but they should certainly not be written back to disk.  That might be a(nother) bug.
Comment 11 allan 2010-05-10 21:13:04 UTC
(In reply to comment #10)
> The internal variables are overridden by the automatic detection of the
> importer but they should certainly not be written back to disk.  That might be
> a(nother) bug.

When I said the settings were not 'retained', what perhaps would have been clearer would have been to say they are not saved.  One can choose a date format on that tab, click OK then reopen it and the settings are not what was selected.
Comment 12 Thomas Baumgart 2010-06-01 09:43:04 UTC
SVN commit 1133094 by tbaumgart:

Fix QIF import dialog sizing problem.
Retain selected date setting of QIF profile

BUG: 234215

 M  +84 -67    kimportdlgdecl.ui  
 M  +11 -3     mymoneyqifprofileeditor.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1133094