Bug 232928 - Digital Clock Widget - Holiday Region Intermixes National & Religious Holidays
Summary: Digital Clock Widget - Holiday Region Intermixes National & Religious Holidays
Status: RESOLVED FIXED
Alias: None
Product: kdepimlibs
Classification: Applications
Component: kholidays (show other bugs)
Version: unspecified
Platform: Debian testing Linux
: NOR wishlist
Target Milestone: ---
Assignee: John Layt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-01 07:18 UTC by north
Modified: 2014-06-20 19:16 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.14


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description north 2010-04-01 07:18:13 UTC
Version:            (using KDE 4.3.4)
OS:                Linux
Installed from:    Debian testing/unstable Packages

Looking at the highlighted days for the holiday region "United States of America", I am a bit puzzled by entries such as "Ascension" and "Trinity". I have never heard of these days before but I assume based on their names that they are Christian religious holidays. This is all good and well except for the fact that I see no reason why these holidays are part of the "United States of America" region.

Passover was last night and I don't seem to see it highlighted anywhere on the calendar. I'm fairly sure it happened as I clearly remember the seder.

I can see only two possible explanations for this:
1: Some developer believes the United States to be a "Christian nation".
2: Certain holidays are considered "universal" and are present in most or all countries.

I think 1 & 2 are both unreasonable as well as opposed to US government policy. Regardless of the explanation, the current setup is problematic for Jews and other non-Christians living in the United States. Additionally, asking someone to use the calendar for another region (such as Isreal) is unreasonable as local US holidays such as Independence Day are just as important to many as religious holidays are. Thus, the current setup is unresolvable and should be considered a bug.

Instead of the current single-select dropdown, I propose that the dialogue should contain a CHECKABLE LIST or some other MULTIPLE-SELECT element containing items such as:

- National Holidays -
☐ United States
☐ United Kingdom
☐ Canada
☐ Germany
etc...

- Religious Holidays -
☐ Jewish
☐ Christian
☐ Buddhist
etc...

- Other Holidays -
☐ Something
☐ More Stuff
☐ bla
etc...
Comment 1 Anne-Marie Mahfouf 2010-04-01 14:31:35 UTC
The holidays used in Plasma calendar are from kdepimlibs/kholidays and you can look at the file on
http://websvn.kde.org/branches/KDE/4.4/kdepimlibs/kholidays/holidays/holiday_us?view=markup

In KDE 4.4.N there are only holidays with a day off which are shown in the Plasma calendar (non working days) (I fixed this at some point). But all those holidays may appear in KOrganizer for example (not sure).

Apparently this bug report that I am reassigning to kholidays should end up on the kde-pim mailing list to which you can also subscribe and propose your ideas. 

The problem you react to is the fact that some holidays in the file are not holidays but Christian days. How will that be specified in the file format and in the KHolidays class in order to parse it later?
Comment 2 north 2010-04-01 18:35:57 UTC
I would suggest that they be moved OUT of the US holiday file and into a separate file containing Christian holidays. That way, software could simply parse the files required. If you wanted US holidays -and- Jewish holidays for example, program X could just read both of them. I don't see why the KHolidays class can only draw from ONE data file. Why not several?

Specifying it in the file format becomes a non-issue at that point, you leave the file format alone and simply move that subsection labeled "Easter related" into another file holidays_christian or something.

The programming aspect of the "fix" in this case is to just allow KHolidays to load multiple data files. If this functionality is already present, the issue becomes a trivial matter of just moving the holidays into their respective files.

Now... as for this file... from the comments it looks like i can just move it into ~/.kholiday/ and it will override the system's version (meaning I could, for example, remove easter and add Passover for my custom file). Is this correct? While not a fix for the larger problem, this would certainly be a short term convenience.
Comment 3 John Layt 2010-04-01 19:47:56 UTC
Indeed, the current KHoliday implementation is very limited in categories of holidays, mostly due to the historic single file selection criteria.  The good news is I'm doing work in 4.5 to implement most of what you suggest, including splitting files up into National, Regional, Religious, and Other holidays, and allowing multiple files to be selected.  You can see the design I'm broadly working to at http://websvn.kde.org/trunk/KDE/kdepimlibs/kholidays/DESIGN?revision=1062110&view=markup .  I've already implemented a new file parser to cope with many of the new features, but haven't had much time to actually do the holiday sub-regions/types just yet.  I'll be back onto this in a couple of weeks.  In the meantime any comments are welcome.
Comment 4 north 2010-04-01 20:26:16 UTC
Yeah I would say that spec you linked to pretty much covers everything I was thinking of.
Comment 5 John Layt 2010-06-06 15:42:47 UTC
In 4.5 we can now distinguish between holidays that are days off and those that are not.  Days off are highlighted in red, those not are highlighted in light green.  Unfortunately we didn't get the ability to select multiple files to display done for 4.5, so the split into separate civil and religious files has been delayed until 4.6.
Comment 6 Marek Laane 2014-01-29 00:23:24 UTC
No progress in last 3.5 years ...
Comment 7 north 2014-01-29 01:01:31 UTC
This kind of just complete lack of giving a shit on the part of literally every FOSS project in the universe is why I bought a Mac. The fact that this kind of shit takes longer than a few days to resolve is proof that when it comes to support and QUALITY, you get what you PAY for.

I can't believe I'm even still subscribed to this shit. Thanks for reminding me to unsubscribe from every bug on this worthless tracker.

(In reply to comment #6)
> No progress in last 3.5 years ...
Comment 8 John Layt 2014-06-20 19:16:30 UTC
Charming, way to motivate volunteers to work on your feature requests.  The ability to split the files by category was implemented in 4.6, it's just no-one on the local team who maintain the files thought that the US file actually needed splitting up, and as an atheist I hardly have the expertise required to compile the list of Jewish holidays. That's where the community is supposed to step in.  Anyway, regardless of your ranting, full category support have been implemented for 4.14 and another community volunteer has stepped up to do the laborious job of splitting the data files and compiling the lists of religious holidays.