Bug 232675 - Konversation doesn't honor mIRC colors in topic
Summary: Konversation doesn't honor mIRC colors in topic
Status: CONFIRMED
Alias: None
Product: konversation
Classification: Applications
Component: general (show other bugs)
Version: 1.5-rc1
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Konversation Developers
URL:
Keywords:
: 99032 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-03-30 11:46 UTC by Martin Herkt
Modified: 2013-04-15 01:38 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Herkt 2010-03-30 11:46:34 UTC
Version:           1.2.3 (using Devel)
OS:                Linux
Installed from:    Compiled sources

Konversation doesn't honor mIRC color codes in the topic line widget and "*** The channel topic is:" info, and completely strips color codes in the channel editor unless the topic has changed at least once during the session (leaving the color codes intact).
Comment 1 Eike Hein 2010-03-30 20:11:58 UTC
*** Bug 99032 has been marked as a duplicate of this bug. ***
Comment 2 Bernd Buschinski 2010-09-09 00:09:39 UTC
commit 57abec5ee9a43bf3d7fde6e67b3c43c96020aaec
Author: Bernd Buschinski <b.buschinski@web.de>
Date:   Tue Sep 7 19:50:28 2010 +0200

    Don't strip irc markups from topic in inputfilter.
    If we strip it here '/topic' will always be colorless.
    NOTE: If we changed the topic with the topiceditor, the
    topic history always had irc markes in it.
    CCBUG:232675

diff --git a/src/irc/inputfilter.cpp b/src/irc/inputfilter.cpp
index 7948c63..240d850 100644
--- a/src/irc/inputfilter.cpp
+++ b/src/irc/inputfilter.cpp
@@ -1092,7 +1092,7 @@ void InputFilter::parseServerCommand(const QString &prefix, const QString &comma
             {
                 if (plHas(3))
                 {
-                    QString topic = Konversation::removeIrcMarkup(trailing);
+                    QString topic(trailing);
 
                     // FIXME: This is an abuse of the automaticRequest system: We're
                     // using it in an inverted manner, i.e. the automaticRequest is
Comment 3 Martin Herkt 2010-09-19 03:55:52 UTC
(In reply to comment #2)

This commit caused a bug:
for example with "%C14http://bugs.kde.org" or "http://bugs.kde.org%C14" in the topic, the color codes won't get stripped from the URL in the topic line widget.