Bug 232057 - Toggle Reminder functionality does not work properly
Summary: Toggle Reminder functionality does not work properly
Status: VERIFIED FIXED
Alias: None
Product: korganizer
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-25 02:09 UTC by Sabine Faure
Modified: 2010-07-29 02:17 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sabine Faure 2010-03-25 02:09:21 UTC
Version:            (using Devel)
Compiler:          gcc 4.3.2 
OS:                Linux
Installed from:    Compiled sources

- Launch KOrg
- Go to Month view
- Create a new event for today
- The event appears correctly in the month view
- Right click on it and select 'Toggle Reminder'
- The reminder icon (red bell) is added next to the title in the details view
- Right click on the event again and select 'Edit...'
- Click on the 'Advanced...' button

The Time section has entered '1 minute after the event starts' as a reminder time by default whereas the table above it displays '0 minutes after the start'.

So if the default reminder is not modified manually then no reminder is set for this event.

The same thing happens when selecting 'Toggle Reminder' for a To-do.

Trunk, Svn Rev 1106990
Comment 1 Laurent Montel 2010-03-25 09:53:33 UTC
SVN commit 1107287 by mlaurent:

Fix reminder time. We can't put 0.
BUG: 232057


 M  +3 -2      calendarview.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1107287
Comment 2 Sabine Faure 2010-03-25 19:29:29 UTC
It is still not yet corrected.

The same message is now displayed both in the Time section and the table: '1 minute after the events starts' but there is no reminder appearing at all whereas it should.

So I am reopening this bug.

Trunk, Svn Rev 1107335
Comment 3 Laurent Montel 2010-03-29 23:13:58 UTC
I spoke with Allen and 0 minute was a feature of 3.5 and he didn't backport all necessary fix, so I will reassign this bug to Allen.
Comment 4 Allen Winter 2010-04-04 19:46:54 UTC
SVN commit 1111040 by winterz:

we allow 0 offsets for the reminder.
CCBUG: 232057

Sabine, please test this now


 M  +0 -1      calendarview.cpp  
 M  +1 -1      incidenceeditor/koeditoralarms_base.ui  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1111040
Comment 5 Sergio Martins 2010-06-01 12:59:06 UTC
Ready to be verified.
Comment 6 Sabine Faure 2010-06-27 23:29:29 UTC
I retested this today and no reminder appears but it seems that the reminder functionality is broken since whatever I do I never get one.

I have reporte a bug about that (bug #242978) and I will retest this after the reminders work again.

Trunk, Svn Rev 1142760
Comment 7 Sabine Faure 2010-07-29 02:17:36 UTC
It is corrected now.

The reminders are correctly set now both on events and to-dos from the Month view.

Trunk, Svn Rev 1156007