Bug 232046 - Wrongly displayed items in the 'Use holiday region:' combo box
Summary: Wrongly displayed items in the 'Use holiday region:' combo box
Status: VERIFIED FIXED
Alias: None
Product: kdepimlibs
Classification: Applications
Component: kholidays (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: John Layt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-24 22:59 UTC by Sabine Faure
Modified: 2010-06-23 21:40 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sabine Faure 2010-03-24 22:59:19 UTC
Version:            (using Devel)
Compiler:          gcc 4.3.2 
OS:                Linux
Installed from:    Compiled sources

- Launch KOrg
- Go to Settings menu/Configure KOrganizer...
- Click on 'Time and Date' icon on the left side
- In the 'Holidays' section try to select your country from the 'Use holiday region' combo box

It is very hard to find since for example instead of France, Fr_Fr is displayed in the list.

There is not one real country name in the combo box list whereas it was not the case last time I tested this.

Trunk, Svn Rev 1106990
Comment 1 Laurent Montel 2010-03-25 09:01:29 UTC
I confirm it it's not easy to find it.
I will look at if it's possible to change it.
Comment 2 Laurent Montel 2010-03-25 09:18:44 UTC
It's a problem in KHoliday/holidayregion.cpp
Comment 3 John Layt 2010-03-25 17:05:24 UTC
I'm doing a re-write on parts of KHolidays, part of which is improving the naming of the files which is currently a WIP.  The old way was OK for files at a national level but failed when you needed regional files or countries with multiple languages.  I'm currently looking at using the iso-codes project as a source of regional translation names (http://pkg-isocodes.alioth.debian.org/), or including the region name inside the file itself.  Either way, I'll have it all sorted for 4.5 :-)
Comment 4 John Layt 2010-05-29 01:20:55 UTC
This should be working fine now, the combo now lists the Country or Region name along with the Language the holiday file is in, which is useful for multilingual countries which have multiple files.
Comment 5 Sabine Faure 2010-06-23 21:40:52 UTC
Indeed it is corrected now.

The user just has to select its country name from the list now.

Trunk, Svn Rev 1141839