Bug 231785 - Highlight when using graphical emoticons
Summary: Highlight when using graphical emoticons
Status: RESOLVED FIXED
Alias: None
Product: konversation
Classification: Applications
Component: general (show other bugs)
Version: 1.2.3
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: Konversation Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-22 15:44 UTC by kde
Modified: 2010-07-16 23:08 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description kde 2010-03-22 15:44:46 UTC
Version:           1.2.3 (using KDE 4.4.1)
OS:                Linux
Installed from:    openSUSE RPMs

I activated graphical emoticons in the conf of Konversation. These emoticons are located somewhere in my home-directory. Now Konversation raises a highlight every time someone uses an emoticon, although my nick isn't mentioned.

My idea: My nickname is the same like the username on my system, so the URL of the emoticons includes my nickname ( /home/<nickname>/.kde4/[...] ). I think Konversation searches for my nickname in the URL and raises a highlight. When I change my nickname I get no highlights any more if theres just an emoticon.

It's not critcal but I'll have to deactivate the highlight or the graphical emoticons til it's fixed :(
Comment 1 Peter Simonsson 2010-07-16 23:08:25 UTC
commit ee5e815f9fe99b88cb9e4a005e4db36fedb8fbb2
Author: Peter Simonsson <peter.simonsson@gmail.com>
Date:   Fri Jul 16 23:08:06 2010 +0200

    Move emoticon parsing after highlight parsing to avoid false highlights
    BUG:231785

diff --git a/src/viewer/ircview.cpp b/src/viewer/ircview.cpp
index 86f8abf..13a0d77 100644
--- a/src/viewer/ircview.cpp
+++ b/src/viewer/ircview.cpp
@@ -1145,8 +1145,6 @@ bool doHighlight, bool parseURL, bool self)
         filteredLine.replace("\x0b", "&");
     }
 
-    filteredLine = Konversation::Emoticons::parseEmoticons(filteredLine);
-
     // Highlight
     QString ownNick;
 
@@ -1245,6 +1243,8 @@ bool doHighlight, bool parseURL, bool self)
             "\">" + filteredLine + "</font>";
     }
 
+    filteredLine = Konversation::Emoticons::parseEmoticons(filteredLine);
+
     // Replace pairs of spaces with "<space>&nbsp;" to preserve some semblance of text wrapping
     filteredLine.replace("  "," \xA0");
     return filteredLine;