Bug 231622 - tasks with special characters fail to upload
Summary: tasks with special characters fail to upload
Status: RESOLVED FIXED
Alias: None
Product: plasma4
Classification: Unmaintained
Component: widget-rememberthemilk (show other bugs)
Version: unspecified
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Andrew Stromme
URL:
Keywords:
: 220311 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-03-22 09:20 UTC by Jeff Trull
Modified: 2010-03-25 23:11 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jeff Trull 2010-03-22 09:20:24 UTC
Version:            (using KDE 4.3.2)
Compiler:          gcc 4.4.1 
OS:                Linux
Installed from:    Ubuntu Packages

Ampersand and plus characters ("&", "+") used in task names don't get added properly.

How to reproduce:

add a task that has only ordinary characters - success
next, add a task that contains the '&' character - applet hangs

This seems to be a UTF-8 quoting issue related to the MD5 signatures.  I observe these messages when I use librtm:

test(9281) RTM::TasksReader::readUnknownElement: Unknown Element:  "StartElement" "err" ""
test(9281) RTM::TasksReader::readUnknownElement: Attributes:
test(9281) RTM::TasksReader::readUnknownElement: "code" "96"
test(9281) RTM::TasksReader::readUnknownElement: "msg" "Invalid signature"                                     

I think bug 220311 may have the same cause.
Comment 1 Dario Andres 2010-03-22 18:42:46 UTC
Fixed in KDE SC 4.4.
Regards

*** This bug has been marked as a duplicate of bug 196909 ***
Comment 2 Dario Andres 2010-03-22 18:56:12 UTC
The reporter noted that he is using librtm from SVN, and that the issue may be different.
Reopening
Comment 3 Andrew Stromme 2010-03-22 20:32:03 UTC
I'm reasonably certain these are different bugs. One had to do with encoding sending things to the server. This seems to be on the receiving end. I'll investigate, thanks for the bug report.
Comment 4 Andrew Stromme 2010-03-22 22:03:34 UTC
Ok, I can reproduce and it's not related to the receiving end. Yeah, I thought I fixed the quoting issue but maybe not.
Comment 5 Andrew Stromme 2010-03-22 22:06:00 UTC
*** Bug 220311 has been marked as a duplicate of this bug. ***
Comment 6 Andrew Stromme 2010-03-22 22:37:35 UTC
SVN commit 1106444 by astromme:

BUG: 231622

Encode arguments in the request URL with percent encoding. Allows the addition of tasks with funky characters such as #,&,+


 M  +1 -1      request.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1106444
Comment 7 Andrew Stromme 2010-03-22 22:38:40 UTC
SVN commit 1106447 by astromme:

CCBUG: 231622
Backport to 4.4

Encode arguments in the request URL with percent encoding. Allows the addition of tasks with funky characters such as #,&,+


 M  +1 -1      request.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1106447
Comment 8 Andrew Stromme 2010-03-22 22:59:03 UTC
This should be fixed in KDE SC 4.4 branch and will be included in KDE SC 4.4.2 to be released on March 30. Thanks for the bug report!
Comment 9 Jeff Trull 2010-03-25 23:11:12 UTC
Just tested from SVN and it's fixed.  Thanks so much for your quick response.