Bug 231468 - some paintops don't paint/work in scratchpad
Summary: some paintops don't paint/work in scratchpad
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Brush engines (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: LukasT
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-20 21:43 UTC by Elián Hanisch
Modified: 2020-10-15 13:42 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Elián Hanisch 2010-03-20 21:43:12 UTC
Version:           2.2 Beta 1 (using 4.4.1 (KDE 4.4.1), Kubuntu packages)
Compiler:          cc
OS:                Linux (i686) release 2.6.31-20-generic

dyna brush and curve brush don't paint anything in the scratchpad.

duplicate seems to paint something but it looks broken? can't tell where is the source or set it
Comment 1 Sven Langkamp 2010-03-21 03:53:36 UTC
The problem is that curve and dyna the image which isn't available in the scratchpad. Not sure how to solve that.
Comment 2 LukasT 2010-03-23 23:12:07 UTC
SVN commit 1106769 by lukast:

o Clean up the code
o Fix the settings serialization/deserialization
o Remove KisImage dependency, so that we can work in Scratchpad

CCBUG:231468

 M  +46 -257   curve_brush.cpp  
 M  +4 -34     curve_brush.h  
 M  +7 -7      kis_curve_paintop.cpp  
 M  +1 -14     kis_curve_paintop.h  
 M  +8 -8      kis_curve_paintop_settings.cpp  
 M  +3 -4      kis_curve_paintop_settings.h  
 M  +22 -25    kis_curve_paintop_settings_widget.cpp  
 M  +7 -5      kis_curve_paintop_settings_widget.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1106769
Comment 3 LukasT 2010-09-16 11:44:03 UTC
SVN commit 1175981 by lukast:

Make dyna paint in scratchpad.

Dyna paintop needs to know the dimension of the canvas,
KisImage is used for it, but scratchpad is KisImage-free,
so use some dummy dimension.

CCBUG:231468

 M  +14 -14    dyna_brush.cpp  
 M  +8 -5      dyna_brush.h  
 M  +6 -3      kis_dyna_paintop.cpp  
 M  +0 -1      kis_dyna_paintop.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1175981
Comment 4 LukasT 2010-09-16 18:39:52 UTC
For users: the duplicate is too complex for scratchpad, so scratchpad is disabled for duplicate.

For developers:
If we manage to get rid of the KisImage in paintops and allow to setup source in the scrathpad, then we can add support to the duplicate too.