Bug 230735 - solid dataengine fires timer for hddtemp every 10 seconds
Summary: solid dataengine fires timer for hddtemp every 10 seconds
Status: RESOLVED FIXED
Alias: None
Product: plasma4
Classification: Plasma
Component: widget-systemmonitor (show other bugs)
Version: unspecified
Platform: openSUSE Unspecified
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-14 18:06 UTC by Stefan Brüns
Modified: 2010-05-25 21:00 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:

Attachments
Proposed solution (2.00 KB, patch)
2010-03-14 18:12 UTC, Stefan Brüns 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Brüns 2010-03-14 18:06:36 UTC 
Version:            (using KDE 4.4.1)
Installed from:    openSUSE RPMs

The timer is fired also when:
- dataengine is not queried at all
- hddtemp is not available
Comment 1 Stefan Brüns 2010-03-14 18:12:57 UTC 
Created attachment 41623 [details]
Proposed solution

Data queried from hddtemp is cached. After the mainloop finishes (and all clients of the dataengine with the same interval are done), the cache is marked as invalid by the timer.
If the connection to hddtemp fails, the timer is not restarted
If the dataengine is not queried at all, the cache is marked as invalid once, but the timer is not restarted.
Comment 2 Beat Wolf 2010-05-18 10:51:59 UTC 
could you please submit this patch to the plasma-mailing list or reviewboard.kde.org? patches usualy get lost in bugzilla. thank you
Comment 3 Beat Wolf 2010-05-25 09:43:26 UTC 
I would like to repeat my request, please submit this patch somehwere, or it will get lost.
Comment 4 Stefan Brüns 2010-05-25 20:41:51 UTC 
http://reviewboard.kde.org/r/4150/
Comment 5 Aaron J. Seigo 2010-05-25 21:00:04 UTC 
SVN commit 1130594 by aseigo:

patch by Stefan Brüns to fix unecessary timers in the solid device engine
BUG:230735


 M  +17 -5     hddtemp.cpp  
 M  +5 -4      hddtemp.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1130594