Bug 229512 - animated brushes broken & crash
Summary: animated brushes broken & crash
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: General (show other bugs)
Version: unspecified
Platform: Compiled Sources Unspecified
: NOR crash
Target Milestone: ---
Assignee: Sven Langkamp
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-05 10:29 UTC by Halla Rempt
Modified: 2010-03-29 16:54 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Halla Rempt 2010-03-05 10:29:43 UTC
Version:            (using Devel)
Installed from:    Compiled sources

When using an animated brush (like the balls of flame), there  is no animation anymore and after a bit of painting: 

Thread 2 (Thread 0xad573b70 (LWP 26414)):
[KCrash Handler]
#6  0xaf9e0b82 in KisBrush::scaleImage (this=0xae0a798, srcBrush=0xe39c378, scale=0.99607843137254903, subPixelX=0.52303569800278638, subPixelY=0.36054195297992919)
    at /home/boud/kde/src/koffice/krita/plugins/paintops/libbrush/kis_brush.cpp:725
#7  0xaf9e34b7 in KisBrush::paintDevice (this=0xae0a798, colorSpace=0x9eb3b50, scale=0.99607843137254903, angle=0, info=..., subPixelX=0.52303569800278638, subPixelY=0.36054195297992919)
    at /home/boud/kde/src/koffice/krita/plugins/paintops/libbrush/kis_brush.cpp:446
#8  0xaf79acdc in KisBrushOp::paintAt (this=0x9e452a8, info=...) at /home/boud/kde/src/koffice/krita/plugins/paintops/defaultpaintops/brush/kis_brushop.cpp:106
#9  0xb708b4a9 in KisPaintOp::paintLine (this=0x9e452a8, pi1=..., pi2=..., savedDist=...) at /home/boud/kde/src/koffice/krita/image/brushengine/kis_paintop.cc:176
#10 0xb708af8b in paintBezierCurve (paintOp=<value optimized out>, pi1=..., control1=..., control2=..., pi2=..., savedDist=...)
    at /home/boud/kde/src/koffice/krita/image/brushengine/kis_paintop.cc:121
#11 0xb708aebc in paintBezierCurve (paintOp=<value optimized out>, pi1=..., control1=..., control2=..., pi2=..., savedDist=...)
    at /home/boud/kde/src/koffice/krita/image/brushengine/kis_paintop.cc:135
#12 0xb708aebc in paintBezierCurve (paintOp=<value optimized out>, pi1=..., control1=..., control2=..., pi2=..., savedDist=...)
    at /home/boud/kde/src/koffice/krita/image/brushengine/kis_paintop.cc:135
#13 0xb708b04e in KisPaintOp::paintBezierCurve (this=0x9e452a8, pi1=..., control1=..., control2=..., pi2=..., savedDist=...) at /home/boud/kde/src/koffice/krita/image/brushengine/kis_paintop.cc:148
#14 0xb707f32d in KisPainter::paintBezierCurve (this=0xa55cc60, pi1=..., control1=..., control2=..., pi2=..., savedDist=...) at /home/boud/kde/src/koffice/krita/image/kis_painter.cc:556
#15 0xb737d206 in FreehandPaintBezierJob::run (this=0xe34e330) at /home/boud/kde/src/koffice/krita/ui/tool/kis_tool_freehand_p.cpp:110
#16 0xb74a67f2 in QThreadPoolThread::run (this=0xe1c3b58) at concurrent/qthreadpool.cpp:106
#17 0xb74b10bf in QThreadPrivate::start (arg=0xe1c3b58) at thread/qthread_unix.cpp:248
#18 0xb74366e5 in start_thread () from /lib/libpthread.so.0
#19 0xb7436600 in ?? () from /lib/libpthread.so.0
Comment 1 Halla Rempt 2010-03-06 12:15:46 UTC
Only the colored animated brushes are broken, and if the use color as mask option is enabled, the colored animated brushes work again. I'm beginning to suspect Cyrille's memory-saving commit for gbr brushes (1097115)
Comment 2 Cyrille Berger 2010-03-24 17:35:14 UTC
did you try to unapply the patch ?
Comment 3 Halla Rempt 2010-03-24 17:36:25 UTC
Not yet, I had actually forgotten about this bug.
Comment 4 Sven Langkamp 2010-03-28 19:26:59 UTC
SVN commit 1108360 by langkamp:

fix animation of imagepipe brushes, overwrite was wrong
CCBUG:229512


 M  +1 -1      kis_imagepipe_brush.cpp  
 M  +4 -4      kis_imagepipe_brush.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1108360
Comment 5 Sven Langkamp 2010-03-29 16:54:08 UTC
SVN commit 1108670 by langkamp:

fix crash and corruption when scaling brush image
BUG:229512


 M  +1 -1      kis_brush.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1108670