Version: (using Devel) Installed from: Compiled sources Due to the removal of the SVN external for libbtcore, kget no longer compiles with torrent support enabled. The attached patch fixes compilation, but I cannot verify its correctness; it has been deduced from the changes made to that library during the time. So please do not apply without someone in the know having a deep look at it. Thanks!
Created attachment 41333 [details] Proposed patch
Well the problem are different versions of libbtcore installed I think... which one do you have? trunk or latest stable-branch? (which would be the one it should compile with...)
I only use trunk.
Yes, I should add a version check... Lukas
*** Bug 229480 has been marked as a duplicate of this bug. ***
Sorry I missed this. I tried to search for something like it, but didn't get all the right keywords. From looking at the libbtcore source in extragear/ktorrent it seems to me that isOk() and isTCPEnabled() are not the same function. Instead, the isOk() function was included into the "initTCPServer()" function which now returns bool instead of void. The patch I provided to the duplicate bug tries to use that functionality instead of isTCPEnabled(). Perhaps I'm mistaken, though...
Comment on attachment 41333 [details] Proposed patch Right, I just made sure it compiles, see the warning above. I will invalidate this patch, since yours from bug 229480 is better.
Well as I commented on the other bug already, we depend on the stable-branched version, which is NOT extragear/network/ktorrent/libbtcore... (I should add version-checks) Anyway, a real fix might come soon as libbtcore is going to get split out of ktorrent even more, so it will be a "proper" library... Lukas
A proper patch has been committed, so this can be closed.
Yes... let's do it... Lukas