Bug 229381 - Edit Account Name Incomplete
Summary: Edit Account Name Incomplete
Status: RESOLVED FIXED
Alias: None
Product: kmymoney
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Unspecified
: NOR normal
Target Milestone: ---
Assignee: KMyMoney Devel Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-04 12:10 UTC by allan
Modified: 2010-03-05 11:33 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description allan 2010-03-04 12:10:56 UTC
Version:           Version 3.96.1-svn1097223 (using KDE 4.3.5)
Installed from:    Compiled From Sources

On attempting to edit an account and investment name, the old name still appears in Accounts View and in the drop-down in Ledger View.

If I enter Accounts View, and select 'Edit Account' for the account in question, the new name is shown as is a note I entered.  If I then click on 'OK', the old name still appears in the account list.  Investment View shows the correct name for the account and for the investment.  In Ledger view, the Account shown is the old name, but all the transactions bear the new name.
Comment 1 Alvaro Soliverez 2010-03-04 16:19:54 UTC
This is probably the accounts model not being refreshed in a timely manner, or not signalling the widgets that an update is needed.

The ledger still has not been ported, that's why it refreshes correctly.
Comment 2 allan 2010-03-04 17:32:58 UTC
I don't know if this is connected, but hours later, I decided to save and reopen, but got an uncaught error - 'Unknown account id 'A000287' in file /home/aga/KMM4/kmymoney/kmymoney/mymoney/storage/mymoneyseqaccessmgr.cpp line 147 , followed by a crash - 

Application: KMyMoney (kmymoney), signal: Aborted
[KCrash Handler]
#6  0xffffe424 in __kernel_vsyscall ()
#7  0xb51770cf in raise () from /lib/libc.so.6
#8  0xb51789e7 in abort () from /lib/libc.so.6
#9  0xb53b403f in __gnu_cxx::__verbose_terminate_handler() () from /usr/lib/libstdc++.so.6
#10 0xb53b1d53 in ?? () from /usr/lib/libstdc++.so.6
#11 0xb53b1d8f in std::terminate() () from /usr/lib/libstdc++.so.6
#12 0xb53b1eb1 in __cxa_throw () from /usr/lib/libstdc++.so.6
#13 0x08092de4 in main (argc=1, argv=0xbf91dfb4) at /home/aga/KMM4/kmymoney/kmymoney/main.cpp:279

QFile::remove: Empty or null file name
Qt has caught an exception thrown from an event handler. Throwing
exceptions from an event handler is not supported in Qt. You must
reimplement QApplication::notify() and catch all exceptions there.

terminate called after throwing an instance of 'MyMoneyException*'


Strangely, that account id. is in the xml file, and is the investment in the account that I was editing.  Also, all names now do show the way I edited them.
Comment 3 Cristian Oneț 2010-03-04 19:03:30 UTC
I fixed the bug but I don't know if the uncaught exception is related. Could you test it again?
Comment 4 allan 2010-03-04 19:36:11 UTC
On Thursday 04 Mar 2010 18:03:32 Cristian Onet wrote:
> https://bugs.kde.org/show_bug.cgi?id=229381
> 
> 
> 
> 
> 
> --- Comment #3 from Cristian Onet <onet cristian gmail com>  2010-03-04
>  19:03:30 --- I fixed the bug but I don't know if the uncaught exception is
>  related. Could you test it again?
> 

I've updated and tested, but the account name still does not get updated.  The 
uncaught error also recurred on closing K.MM.

Allan
Comment 5 Cristian Oneț 2010-03-04 19:49:16 UTC
(In reply to comment #4)
> On Thursday 04 Mar 2010 18:03:32 Cristian Onet wrote:
> > https://bugs.kde.org/show_bug.cgi?id=229381
> > 
> > 
> > 
> > 
> > 
> > --- Comment #3 from Cristian Onet <onet cristian gmail com>  2010-03-04
> >  19:03:30 --- I fixed the bug but I don't know if the uncaught exception is
> >  related. Could you test it again?
> > 
> 
> I've updated and tested, but the account name still does not get updated.  The 
> uncaught error also recurred on closing K.MM.
> 
> Allan

Are you sure your revision is >=1098937? There are moments when it takes a while for changes from svn.kde.org to reach anonsvn.kde.org.
Comment 6 allan 2010-03-04 21:24:07 UTC
On Thursday 04 Mar 2010 18:49:17 Cristian Onet wrote:
> https://bugs.kde.org/show_bug.cgi?id=229381
> 
> 
> 
> 
> 
> --- Comment #5 from Cristian Onet <onet cristian gmail com>  2010-03-04
>  19:49:16 --- (In reply to comment #4)
> 
> > On Thursday 04 Mar 2010 18:03:32 Cristian Onet wrote:
> > > https://bugs.kde.org/show_bug.cgi?id=229381
> > >
> > >
> > >
> > >
> > >
> > > --- Comment #3 from Cristian Onet <onet cristian gmail com>  2010-03-04
> > >  19:03:30 --- I fixed the bug but I don't know if the uncaught
> > > exception is related. Could you test it again?
> >
> > I've updated and tested, but the account name still does not get updated.
> >  The uncaught error also recurred on closing K.MM.
> >
> > Allan
> 
> Are you sure your revision is >=1098937? There are moments when it takes a
> while for changes from svn.kde.org to reach anonsvn.kde.org.
> 

Hi Cristian

I'm new to KDESvn, but I can see in my working copy that in it 
/kmymoney/kmymoney/models/accountsmodel.cpp is at 1098937, and I've rebuilt 
since.  Looking at it directly via Konqueror, it shows a current file 028886 
bytes.  Also, in build there is accountsmodel.moc dated tonight.

I've retried, edited an investment account name, and again the accounts list 
does not update.  I then tried to reopen a closed account a couple of times, 
but that doesn't seem to work here either.

Allan
Comment 7 Cristian Oneț 2010-03-05 07:56:09 UTC
I've managed to track down the way to reproduce the crash. The file must be closed while an investment account is selected. I'll fix this bug but the renaming works fine here. Am I missing something?
Comment 8 Cristian Oneț 2010-03-05 08:44:53 UTC
SVN commit 1099195 by conet:

BUG 229381
Fixed crash while closing the file from the accounts view with an investment account selected.

 M  +7 -0      models/models.cpp  
 M  +6 -0      models/models.h  
 M  +3 -0      views/kmymoneyview.cpp

This fixes the crash, I don't know why the bug was not closed based on the commit message and as I said before the renaming works fine here.
Comment 9 allan 2010-03-05 11:33:52 UTC
Did a further checkout into a new dir. and all now seems fine.  Will have a look back later at what happened. Thanks.