Bug 229348 - Kfind no longer seemd to be able to find text inside of text files.
Summary: Kfind no longer seemd to be able to find text inside of text files.
Status: RESOLVED FIXED
Alias: None
Product: kfind
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Unassigned bugs mailing-list
URL:
Keywords:
: 230851 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-03-04 03:47 UTC by Texstar
Modified: 2010-03-24 15:26 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Patch that reverts part of the broken commit (381 bytes, patch)
2010-03-04 15:50 UTC, Fabio Bas
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Texstar 2010-03-04 03:47:08 UTC
Version:           4.4.1 (using KDE 4.4.1)
Compiler:          gcc version 4.4.1 (GCC) 
OS:                Linux
Installed from:    Unlisted Binary Package

After upgrading to KDE 4.4.1 kfind doesn't seem to be able to find search words within text files. 

PCLinuxOS 2010
gcc 4.4.1
kde 4.4.1 SC
qt4 4.6.0
Comment 1 Texstar 2010-03-04 08:36:47 UTC
Kfind from kdebase-4.4.0 works as intended.
Comment 2 Burkhard Lück 2010-03-04 09:19:58 UTC
confirmed in recent trunk + branch compiled from sources
Comment 3 Fabio Bas 2010-03-04 15:50:19 UTC
Created attachment 41328 [details]
Patch that reverts part of the broken commit
Comment 4 Fabio Bas 2010-03-04 15:51:00 UTC
This regression is caused by the change made in r1092334  on the file kdebase/apps/kfind/kquery.cpp : http://websvn.kde.org/branches/KDE/4.4/kdebase/apps/kfind/kquery.cpp?r1=1070858&r2=1092334&pathrev=1092334
That "if (str.isEmpty()) break;" makes kfind skip every file that has at least one empty line.
Comment 5 Burkhard Lück 2010-03-04 17:05:42 UTC
Indeed, reverting commit 1092334 and rebuilding in branch fixes this bug for me.
CC'ing Darío Andrés Rodríguez, who commited rev 1092334
Comment 6 Dario Andres 2010-03-04 22:15:38 UTC
Ha, I'm a big idiot.. let me revert the commit
Comment 7 Dario Andres 2010-03-04 22:22:11 UTC
SVN commit 1098985 by darioandres:

Backport svn rev. 1098983
Dear stupid me: don't commit stupid changes without testing them.... Thanks
- Fix KFind not being able to search in file contents..
BUG: 229348


 M  +1 -1      kquery.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1098985
Comment 8 Dario Andres 2010-03-05 00:43:03 UTC
Fixed for KDE SC 4.4.2. Blame me :D
Comment 9 Dario Andres 2010-03-15 22:27:55 UTC
*** Bug 230851 has been marked as a duplicate of this bug. ***
Comment 10 0e8h 2010-03-24 08:02:23 UTC
Ridiculous that people have to wait till 4.4.2 when this is a vital feature.

These are the types of situations that make Linux second rate.  I personally decided to install ubuntu-gnome to see if I could get search working, but gnome is so basic and pathetic compared to KDE-Kubuntu that I quickly returned.  What am I to do in the mean time.  I now have to search for repositories to allow the new version of KDE.
Comment 11 Fabio Bas 2010-03-24 09:29:54 UTC
(In reply to comment #10)
> Ridiculous that people have to wait till 4.4.2 when this is a vital feature.

4.4.2 will be tagged tomorrow april, the 25th. You can always compile a patched version of kfind by yourself or, if this is really so vital for you, create a patched package for others to take advantage of.

> 
> These are the types of situations that make Linux second rate.  I personally
> decided to install ubuntu-gnome to see if I could get search working, but gnome
> is so basic and pathetic compared to KDE-Kubuntu that I quickly returned.  What
> am I to do in the mean time.  I now have to search for repositories to allow
> the new version of KDE.

Thank you for your constructive comment </sarcasm>, please remember that these people are working free for you and everyone else.
Comment 12 Texstar 2010-03-24 10:06:04 UTC
It was fixed in the KDE branch and your distribution could have provided the fix in an updated package. I did for PCLinuxOS.
Comment 13 0e8h 2010-03-24 11:56:16 UTC
(In reply to comment #11)
> (In reply to comment #10)
> 
> 4.4.2 will be tagged tomorrow april, the 25th. You can always compile a patched
> version of kfind by yourself or, if this is really so vital for you, create a
> patched package for others to take advantage of.

Thank you!  I'm yet to understand the concepts behind linux patching and version system.

> Thank you for your constructive comment </sarcasm>, please remember that these
> people are working free for you and everyone else.

Why do something if you aren't aiming for the top. Isn't linux about the mission to make it the best OS out there?  If so we all should be thinking of what's needed for both expert and noob.  Features like a working search are very important and need to be working 100% of time.  So when an error is found  it should be purged asap and made fixed for all users.

I'm doing my own contributions to society that others access for free, so I'm not being ungrateful as I truly understand the efforts and honour needed.
Comment 14 Dario Andres 2010-03-24 12:50:14 UTC
@0e8h: you may want to contact your distribution developers/maintainer and ask them to include the commit (http://websvn.kde.org/?view=rev&revision=1098985) in the stable KDE SC 4.4.1 packages. Sorry about the trouble.

An alternative is a CLI application: look at http://www.64bitjungle.com/ubuntu/search-file-contents-in-multiple-directories-with-recursive-grep/  Hope it helps you a bit

Any other kind of discussion is out of the context of this bug report.
Regards
Comment 15 0e8h 2010-03-24 15:26:23 UTC
(In reply to comment #14)
> @0e8h: you may want...

Many Thanks Dario.