Version: 4.4.1 (using KDE 4.4.1) Compiler: gcc version 4.4.1 (GCC) OS: Linux Installed from: Unlisted Binary Package After upgrading to KDE 4.4.1 kfind doesn't seem to be able to find search words within text files. PCLinuxOS 2010 gcc 4.4.1 kde 4.4.1 SC qt4 4.6.0
Kfind from kdebase-4.4.0 works as intended.
confirmed in recent trunk + branch compiled from sources
Created attachment 41328 [details] Patch that reverts part of the broken commit
This regression is caused by the change made in r1092334 on the file kdebase/apps/kfind/kquery.cpp : http://websvn.kde.org/branches/KDE/4.4/kdebase/apps/kfind/kquery.cpp?r1=1070858&r2=1092334&pathrev=1092334 That "if (str.isEmpty()) break;" makes kfind skip every file that has at least one empty line.
Indeed, reverting commit 1092334 and rebuilding in branch fixes this bug for me. CC'ing Darío Andrés Rodríguez, who commited rev 1092334
Ha, I'm a big idiot.. let me revert the commit
SVN commit 1098985 by darioandres: Backport svn rev. 1098983 Dear stupid me: don't commit stupid changes without testing them.... Thanks - Fix KFind not being able to search in file contents.. BUG: 229348 M +1 -1 kquery.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1098985
Fixed for KDE SC 4.4.2. Blame me :D
*** Bug 230851 has been marked as a duplicate of this bug. ***
Ridiculous that people have to wait till 4.4.2 when this is a vital feature. These are the types of situations that make Linux second rate. I personally decided to install ubuntu-gnome to see if I could get search working, but gnome is so basic and pathetic compared to KDE-Kubuntu that I quickly returned. What am I to do in the mean time. I now have to search for repositories to allow the new version of KDE.
(In reply to comment #10) > Ridiculous that people have to wait till 4.4.2 when this is a vital feature. 4.4.2 will be tagged tomorrow april, the 25th. You can always compile a patched version of kfind by yourself or, if this is really so vital for you, create a patched package for others to take advantage of. > > These are the types of situations that make Linux second rate. I personally > decided to install ubuntu-gnome to see if I could get search working, but gnome > is so basic and pathetic compared to KDE-Kubuntu that I quickly returned. What > am I to do in the mean time. I now have to search for repositories to allow > the new version of KDE. Thank you for your constructive comment </sarcasm>, please remember that these people are working free for you and everyone else.
It was fixed in the KDE branch and your distribution could have provided the fix in an updated package. I did for PCLinuxOS.
(In reply to comment #11) > (In reply to comment #10) > > 4.4.2 will be tagged tomorrow april, the 25th. You can always compile a patched > version of kfind by yourself or, if this is really so vital for you, create a > patched package for others to take advantage of. Thank you! I'm yet to understand the concepts behind linux patching and version system. > Thank you for your constructive comment </sarcasm>, please remember that these > people are working free for you and everyone else. Why do something if you aren't aiming for the top. Isn't linux about the mission to make it the best OS out there? If so we all should be thinking of what's needed for both expert and noob. Features like a working search are very important and need to be working 100% of time. So when an error is found it should be purged asap and made fixed for all users. I'm doing my own contributions to society that others access for free, so I'm not being ungrateful as I truly understand the efforts and honour needed.
@0e8h: you may want to contact your distribution developers/maintainer and ask them to include the commit (http://websvn.kde.org/?view=rev&revision=1098985) in the stable KDE SC 4.4.1 packages. Sorry about the trouble. An alternative is a CLI application: look at http://www.64bitjungle.com/ubuntu/search-file-contents-in-multiple-directories-with-recursive-grep/ Hope it helps you a bit Any other kind of discussion is out of the context of this bug report. Regards
(In reply to comment #14) > @0e8h: you may want... Many Thanks Dario.