Bug 229311 - 'Undo' menu item not implemented
Summary: 'Undo' menu item not implemented
Status: VERIFIED FIXED
Alias: None
Product: korganizer
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
: 229313 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-03-03 21:59 UTC by Sabine Faure
Modified: 2010-07-08 21:35 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sabine Faure 2010-03-03 21:59:03 UTC
Version:            (using Devel)
Compiler:          gcc 4.3.2 
OS:                Linux
Installed from:    Compiled sources

- Launch KOrg
- Create a new event called 'test'
- Reopen it and modify the event name into 'test 1'
- Go to Edit menu and select 'Undo'

Nothing happens whereas the name of the event should be reset to 'test'.

Whatever the change the user makes to the event (time, duration, time zone, reminder, description...) when clicking on Undo the change(s) are not reverted but the undo functionality becomes unavailable (greyed)

Trunk, Svn Rev 1098377
Comment 1 Laurent Montel 2010-03-04 10:29:53 UTC
same for redo, not implemented in trunk
Comment 2 Laurent Montel 2010-03-04 11:15:41 UTC
*** Bug 229313 has been marked as a duplicate of this bug. ***
Comment 3 Sabine Faure 2010-04-16 20:41:09 UTC
Also the shortcut for undo: Ctrl+Z is not working atm.

Trunk Svn Rev 1115397
Comment 4 Sergio Martins 2010-05-20 12:15:24 UTC
SVN commit 1128809 by smartins:

Ported history/undo/redo to akonadi.

Now that the changes are async, i need to disable undoing while the previous one is still running or queue the adds and deletes in incidenceChanger because
if the user fires a bunch of undos and redos we must guarantee the order of execution.

CCBUG: 229311


 M  +7 -5      calendarview.cpp  
 M  +52 -65    history.cpp  
 M  +26 -11    history.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1128809
Comment 5 Sergio Martins 2010-05-21 12:01:26 UTC
Try again please.
Comment 6 Sabine Faure 2010-05-21 21:05:34 UTC
It does not work atm unless you do the following:
- Launch KOrg
- Create a new event called 'test'
- Quit KOrg
- Relaunch it
- Reopen the event and modify the event name into 'test 1'
- Go to Edit menu and select 'Undo'

If you do not quit and relaunch KOrg before editing the event then it does not work.

Trunk, Svn Rev 1129177
Comment 7 Sabine Faure 2010-07-08 21:35:05 UTC
It is corrected now.

I retested this today and undo works fine now.

Trunk, Svn Rev 1147490