Version: (using KDE 4.4.0) Compiler: gcc-4.3 OS: Linux Installed from: Gentoo Packages When parley checks for correct synonyms it only checks the direct synonyms. Because of bug 212306 we cannot save multiple synonyms if there is a circular connection between these synonyms, e.g. A=B=C=A . I propose a patch to check synonyms in a transitive way. So if we have something like the following A=B and B=C than entering C if A is asked should still be okay.
Created attachment 41156 [details] Check synonyms in a transitive way A patch that does the things I described in the bug
Checking synonyms is tricky and I don't think that checking them in a transitive way is a good idea. Sure, adding all synonyms is more work if you have lots of them, but thanks to your other patch for bug 212306 this should be fixed soon. :) The reason for why I'm against this is that it might accept more as correct than it should since synonyms almost never have exactly the same meaning and there are words with different meanings. For example, "fix" can mean both "attach" and "repair", but we don't want to accept "attach" if you are asked to enter "repair". So, are you okay if I close this bug as WONTFIX? If there are other important reasons why we need this, I'd be happy to hear them.
If the patch for bug #212306 is accepted it would be okay to close this. The main reason we added the patch was that we used synonyms as multiple translations for the same word. So for example in Japanese language there are 4 or more translations for thank you. Its just a big hassle to add them all. Also I wrote this patch first as it was easier :) What I would think is a good idea is that the editor checks upon entering a new word, if a word with the same spelling is already in another lesson and asks if the new word should be added as a synonym ?
Since the bug 212306 is closed and per Benjamins comment "If the patch for bug #212306 is accepted it would be okay to close this" I will hereby close this bug. And for the record, I also agree with Daniels comment that checking synonyms transitively is tricky and not always a good idea.