Bug 228696 - 'Unable to save changes for incidence... aborting Store' error message when moving an event while editing it
Summary: 'Unable to save changes for incidence... aborting Store' error message when m...
Status: RESOLVED WORKSFORME
Alias: None
Product: korganizer
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Sergio Martins
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-27 01:32 UTC by Sabine Faure
Modified: 2010-12-27 02:14 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sabine Faure 2010-02-27 01:32:12 UTC
Version:            (using Devel)
Compiler:          gcc 4.3.2 
OS:                Linux
Installed from:    Compiled sources

- Launch KOrg
- Create a new event and click on 'Ok'
- Double click on the event to reopen it
- Drag and drop the event one hour earlier in the agenda view and nearly at the same time, click on the 'Ok' button from the 'Edit Event' dialogue
- A 'Sorry' pop up dialogue appears with the following message: 'Unable to save changes for incidence Event ''NAMEOFTHEEVENT': Unknown error. (No Item was modified elsewhere, aborting STORE.)

If you are not fast enough a different message appears: 'Incidence changed, reloading the event'

- Click on 'Ok'
- Reopen the event you've just moved and you can see that the Calendar: combo box is now empty and unavailable (greyed).

It is now impossible to create or modify events since it is impossible to select a calendar to store it in.

The only way to restore the Calendar combo box is to log out and then log back in.

Debug info given by Sérgio Martins (Kudos for being able to reproduce this nasty bug! ;o):
Before changing an incidence korganizer calls mChanger->begin( inc ) which locks the inc and returns true, if the incidence is already being changed it returns false, this avoids nested changes. When mChanger->end() is 
called the lock is cleared.
That was before akonadi, now it's async, and the changejob sometimes returns after mChanger->end() was called, allowing nested changes.

Trunk, Svn Rev 1096391
Comment 1 Sabine Faure 2010-03-04 21:39:44 UTC
Another way to reproduce this bug is this:
- Launch KOrg
- Create a weekly recurring event
- Right click on the second occurence of the recurring event and select 'Dissociate From Recurrence...'
- A pop up dialogue appears, in it select 'Also Dissociate Futures Ones'
- Drag and drop the event one hour earlier
- A pop up dialogue appears, in it select 'Only this item'
- A 'Sorry' pop up dialogue appears with the following message: 'Unable to save
changes for incidence Event ''NAMEOFTHEEVENT': Unknown error. (No Item was
modified elsewhere, aborting STORE.). 
Or if you wait too long you do not get the error message and instead the event disappears from the agenda view. After you log out and then back in the event has been moved correctly.

In both cases it is now impossible to create new events since it is impossible to select a calendar to store them in (the calendar combo box is empty and greyed).

Trunk, Svn Rev 1098884
Comment 2 Sergio Martins 2010-03-22 17:27:32 UTC
SVN commit 1106371 by smartins:

With akonadi, incidence changing is async so we can't cleanup+unlock in IncidenceChanger::endChange() anymore, only when the 
incidence is actually modified.

Fixes some cases where the "No Item was modified elsewhere, aborting STORE" appeared.

There are more causes, will fix them next.

CCBUG: 228696

MERGE: none


 M  +25 -11    incidencechanger.cpp  
 M  +9 -6      incidenceeditor/koeventeditor.cpp  
 M  +9 -6      incidenceeditor/kojournaleditor.cpp  
 M  +10 -7     incidenceeditor/kotodoeditor.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1106371
Comment 3 Sergio Martins 2010-03-22 18:23:52 UTC
SVN commit 1106379 by smartins:

Don't start two modify jobs on the same item revision.

No more STORE messages from akonadi.

CCBUG: 228696

MERGE: none


 M  +10 -0     incidencechanger.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1106379
Comment 4 Sergio Martins 2010-03-22 19:18:55 UTC
Retest please. (r1106379)
Comment 5 Sabine Faure 2010-03-24 22:42:24 UTC
It not corrected (I do get a new error message before the Store error) so I am reopening this bug.

Here are the steps to reproduce it:
- Launch KOrg
- Create a new event and click on 'Ok'
- Drag and drop the event one hour earlier in the agenda view several times very fast
- a new pop up message appears: 'Unable to lock item for modification. You cannot make any changes'
- wait a minute without doing anything and the Store error message appears: 'Unable to save changes for incidence 'Nameoftheevent': Unknow error. (NO Item was modified elsewhere, aborting STORE.)

Trunk, Svn Rev 1106990
Comment 6 Sergio Martins 2010-12-27 02:14:17 UTC
Fixed here.