Bug 227767 - Plasma lacks Containments scripted support
Summary: Plasma lacks Containments scripted support
Status: RESOLVED LATER
Alias: None
Product: plasma4
Classification: Unmaintained
Component: scriptengines (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-20 02:47 UTC by Vincenzo Di Massa
Modified: 2010-03-12 14:34 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
sip file patch (608 bytes, patch)
2010-02-20 02:48 UTC, Vincenzo Di Massa
Details
calls Applet::init() (335 bytes, patch)
2010-02-20 02:49 UTC, Vincenzo Di Massa
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Vincenzo Di Massa 2010-02-20 02:47:57 UTC
Version:            (using Devel)
OS:                Linux
Installed from:    Compiled sources

The python bindings have a bug which prevents Containments to be returned from the engine.

Moreover if the scripted Applet is a containment it never reaches Applet::init() which calls AppletPrivate::setupScriptSupport().

I will provide a couple of patches for you to review.
Comment 1 Vincenzo Di Massa 2010-02-20 02:48:54 UTC
Created attachment 40946 [details]
sip file patch
Comment 2 Vincenzo Di Massa 2010-02-20 02:49:45 UTC
Created attachment 40947 [details]
calls Applet::init()
Comment 3 Vincenzo Di Massa 2010-02-23 12:51:42 UTC
I did not mark it as a wish because I feel the scripting support for containers is mostly done, but bugs (in plasma and kdebindings) prevent it from working. Of course this bug also implies the whish of better scripting support, but filing some bugs and a wish did not make sense to me. [OT maybe bugzilla could benefit from a directory/subdirectory or tagging mechanism?]

Anyhow, did anyone test the patches yet?
Comment 4 Beat Wolf 2010-02-23 13:02:09 UTC
reviewboard.kde.org or the plasma mailing list are better to submit patches.
Comment 5 Vincenzo Di Massa 2010-03-12 14:10:19 UTC
The patch got approved by aseigo: I will commit it later.
Comment 6 Richard Dale 2010-03-12 14:34:23 UTC
On Friday 12 March 2010 01:10:24 pm Vincenzo Di Massa wrote:
> https://bugs.kde.org/show_bug.cgi?id=227767
> 
> 
> Vincenzo Di Massa <hawk.it@tiscali.it> changed:
> 
>            What    |Removed                     |Added
> ---------------------------------------------------------------------------
> - Status|UNCONFIRMED                 |RESOLVED
>          Resolution|                            |LATER
> 
> 
> 
> 
> --- Comment #5 from Vincenzo Di Massa <hawk it tiscali it>  2010-03-12
> 14:10:19 --- The patch got approved by aseigo: I will commit it later.
I've already added the change to Containment::init() the other week..

-- Richard