Bug 227684 - Line edit not empty in the edit categories dialogue
Summary: Line edit not empty in the edit categories dialogue
Status: RESOLVED FIXED
Alias: None
Product: korganizer
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: LO normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-19 16:27 UTC by Sabine Faure
Modified: 2015-03-12 08:34 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
CategoryEditDialog diff (1.70 KB, patch)
2010-02-22 18:47 UTC, Julia Medvedeva
Details
trunk/KDE/kdepim/libkdepim/categoryeditdialog.cpp (6.08 KB, patch)
2010-02-26 17:41 UTC, Julia Medvedeva
Details
trunk/KDE/kdepim/libkdepim/categoryeditdialog.h (500 bytes, patch)
2010-02-26 17:42 UTC, Julia Medvedeva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sabine Faure 2010-02-19 16:27:45 UTC
Version:            (using Devel)
Compiler:          gcc 4.3.2 
OS:                Linux
Installed from:    Compiled sources

- Launch Kontact and go to KOrg
- Click on the 'New Event' button from the main tool bar
- Click on the 'Select...' button to select a category
- Click on the 'Edit Categories...' button.
- The 'Edit Categories - Kontact' dialogue appears. In it there is a line edit.
- By default the line edit is not empty, it displays the first category (ex:Anniversary).

This is confusing because if the user clears the line edit then the category is erased whereas there is a 'remove' button just for that.

So I think it would be better if the line edit was empty by default when the dialogue appears.

Trunk, Svn Rev 1092481
Comment 1 Sabine Faure 2010-02-19 16:33:54 UTC
In fact it would even be better if the line edit was greyed (unavailable) until the user clicked on a button to add a category name or until after he selected a category and clicked on the 'add a subcategory' button to add a subcategory name.

Trunk, svn Rev 1092481
Comment 2 Julia Medvedeva 2010-02-22 18:47:23 UTC
Created attachment 41014 [details]
CategoryEditDialog diff

1.When the dialog opens (when is called the method “show”)- no one category is selected and the LineEdit (mEdit class) is empty and is disabled.
2.The LineEdit (mEdit class) is enabling if is selected only ONE category. When is selected several categories the LineEdit is disabled.
3.The button “Add subcategory” is enabling if is selected only ONE category, which would be the parent’s category for new category.
4.The button “Remove” is enabling if is selected one or more categories. 
5.In source the active item is selected item. The processing of Current Item was deleted.
Comment 3 Julia Medvedeva 2010-02-23 14:31:21 UTC
The patch for trunk/KDE/kdepim/libkdepim/categoryeditdialog.h   and
trunk/KDE/kdepim/libkdepim/categoryeditdialog.cpp
Comment 4 Laurent Montel 2010-02-26 13:57:53 UTC
I don't get patch.
Could you readd it without zip it please.
Comment 5 Julia Medvedeva 2010-02-26 17:41:43 UTC
Created attachment 41142 [details]
trunk/KDE/kdepim/libkdepim/categoryeditdialog.cpp
Comment 6 Julia Medvedeva 2010-02-26 17:42:23 UTC
Created attachment 41143 [details]
trunk/KDE/kdepim/libkdepim/categoryeditdialog.h
Comment 7 Laurent Montel 2015-03-12 08:34:05 UTC
code was changed and it's fixed now