Bug 227540 - JJ: checkbox instead of radiobox in opacity settings
Summary: JJ: checkbox instead of radiobox in opacity settings
Status: RESOLVED FIXED
Alias: None
Product: kwin
Classification: Plasma
Component: general (show other bugs)
Version: unspecified
Platform: Fedora RPMs Unspecified
: NOR wishlist
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2010-02-18 17:42 UTC by Felix Möller
Modified: 2010-03-20 14:57 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
Fixes fish user/group delimiter problem (1011 bytes, patch)
2010-03-16 04:36 UTC, Glen Kaukola 		Details
Group the opacity actions. (1.63 KB, patch)
2010-03-16 07:00 UTC, Glen Kaukola 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Felix Möller 2010-02-18 17:42:18 UTC 
Version:            (using KDE 4.4.0)
Installed from:    Fedora RPMs

See attached screenshot.

Just one entry can be selected so this has to be a radio box.
Comment 1 CAI Qian 2010-02-28 13:52:31 UTC 
Where is the attachment?
Comment 2 Christoph Feck 2010-02-28 13:57:32 UTC 
We don't need a screen shot, as that bug is easily reproducible.
Comment 3 Glen Kaukola 2010-03-16 04:36:44 UTC 
Created attachment 41677 [details]
Fixes fish user/group delimiter problem

Fixes fish user/group delimiter problem.
Comment 4 Christoph Feck 2010-03-16 04:51:48 UTC 
The patch is for bug 227678 ...
Comment 5 Glen Kaukola 2010-03-16 05:14:13 UTC 
Yeah, sorry about that.  I blew it.
Comment 6 Glen Kaukola 2010-03-16 06:55:39 UTC 
Actually a screenshot would have helped me figure out what this was about.  Anyhow, I'm attaching a patch for this one.  Any criticism will be appreciated.

Seems to me "To Desktop" could use the same treatment.  And perhaps "Move window to group" as well.  Although I have no idea how to create window groups at this point so I can't say for sure.
Comment 7 Glen Kaukola 2010-03-16 07:00:17 UTC 
Created attachment 41679 [details]
Group the opacity actions.
Comment 8 Martin Flöser 2010-03-20 14:57:35 UTC 
SVN commit 1105530 by graesslin:

Use radiobuttons instead of checkboxes in opacity user actions menu.
Thanks to Glen Kaukola for the patch.
FEATURE: 227540

 M  +2 -0      useractions.cpp  
 M  +2 -0      workspace.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1105530