Bug 227114 - Confusing konsole scrollback settings
Summary: Confusing konsole scrollback settings
Status: RESOLVED FIXED
Alias: None
Product: konsole
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Gentoo Packages Unspecified
: NOR wishlist
Target Milestone: ---
Assignee: Konsole Developer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-16 02:34 UTC by Kévin FERRARE
Modified: 2011-10-25 11:45 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.8


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kévin FERRARE 2010-02-16 02:34:13 UTC
Version:            (using KDE 4.4.0)
Installed from:    Gentoo Packages

When you make a change in the Scrollback->Scrollback options settings window, the change is only applied to the current session and not saved if the "Save to current profile" checkbox is not checked.
This checkbox should be checked by default or shouldn't even be there.
This is confusing when you change a setting and realize after restarting the program that it hasn't been changed.
My 2c of kde usability improvement
Comment 1 Kurt Hindenburg 2010-02-16 17:58:41 UTC
You are likely correct.  I think most will want to save it to their profile.
Comment 2 Robert Knight 2010-02-17 00:37:58 UTC
I personally adjust this setting for individual tabs quite frequently.  This is one of the options which I think is very useful to be able to set per-tab and not just for all tabs using a particular profile.

The same applies to the encoding option and the 'Rename Tab' function.
Comment 3 Kévin FERRARE 2010-03-03 02:26:18 UTC
I think it's OK to have both possibilities, but the interface as it is now is confusing.
Maybe making 2 buttons "Save" and "Apply only to this tab" would be clearer ?
Comment 4 Jekyll Wu 2011-09-12 21:49:08 UTC
I personally agree that "Save to current profile"" checkbox should be removed, but the modification made in that dialog should always be one-shot, instead of being persistent and influencing other tabs using the same profile. That make it consistent with other actions in the context menu; both 'Set encoding' and 'Change profile' actions are one-shot, only influencing current tab.

In general, I think the 'Edit Profile' dialog should be the only place where modification can be saved persistently.That would simplify both the concept and implementation.

And I think that 'Defaults' button is also confusing. Does it mean using current value, or the value defined in the profile, or using some default value predefined in the source code?

My suggestion is removing both the 'Save to current profile' checkbox and 'Defaults' button. It might be a good a idea to add a label indicating modification made in this dialog is just one-shot.
Comment 5 Jekyll Wu 2011-10-25 11:45:58 UTC
Git commit 8f7be18a64cfb5a25f87d0348eb48566cbd6d4e8 by Jekyll Wu.
Committed on 25/10/2011 at 10:53.
Pushed by jekyllwu into branch 'master'.

Simplify the scrollback setting dialog to avoid potential confusion.

  - the change is not saved into profile and only influences current tab
  - remove the 'Save to current profile' checkbox
  - remove the 'Defaults' button
  - change dialog title from "Scrollback Options" to "Adjust Scrollback"
  - change action from "Scrollback Options..." to "Adjust Scrollback..."

The new dialog makes the "Adjust Scrollback..." action more consistent with
most
of other actions in the context menu, since they only influence or work in the
context of current tab.

The UI change is not quite satisfactory. Feel free to refine the UI part
to make it more clear and elegant.

BUG: 227114
FIXED-IN : 4.8
REVIEW: 102688

M  +2    -2    desktop/partui.rc
M  +2    -2    desktop/sessionui.rc
M  +7    -42   src/HistorySizeDialog.cpp
M  +1    -27   src/HistorySizeDialog.h
M  +6    -24   src/SessionController.cpp
M  +1    -1    src/SessionController.h

http://commits.kde.org/konsole/8f7be18a64cfb5a25f87d0348eb48566cbd6d4e8