Bug 226710 - Device notifier window too small hides the mount/umount button
Summary: Device notifier window too small hides the mount/umount button
Status: RESOLVED FIXED
Alias: None
Product: plasma4
Classification: Plasma
Component: widget-devicenotifier (show other bugs)
Version: unspecified
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-13 19:10 UTC by mickael.chazaux
Modified: 2010-05-26 18:28 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
A screenshot showing the problem (92.90 KB, image/png)
2010-03-04 13:36 UTC, mickael.chazaux
Details
snapshot spanish translation (18.85 KB, image/jpeg)
2010-05-08 01:09 UTC, Iker salmón
Details

Note You need to log in before you can comment on or make changes to this bug.
Description mickael.chazaux 2010-02-13 19:10:01 UTC
Version:            (using KDE 4.4.0)
OS:                Linux
Installed from:    Gentoo Packages

At least in the French locale, the window of the devicenotifier plasmoid is too small to display correctly the mount/umount button. When used in a panel this makes the button invisible in the pop-up. When used on the desktop, the window is also too small, and the buttons and actions are visible, but outside the window. This simple patch makes the device notifier usable in french : 

kdebase-workspace-4.4.0/plasma/generic/applets/devicenotifier $ diff -BuN notifierdialog.cpp.old notifierdialog.cpp
--- notifierdialog.cpp.old      2010-02-13 18:57:10.000000000 +0100
+++ notifierdialog.cpp  2010-02-13 18:20:39.000000000 +0100
@@ -504,7 +504,7 @@
     updateMainLabelText();

     m_widget->setLayout(l_layout);
-    m_widget->setMinimumSize(250, 300);
+    m_widget->setMinimumSize(350, 400);
 }

 void NotifierDialog::storageTeardownDone(Solid::ErrorType error, QVariant errorData, const QString & udi)
Comment 1 mickael.chazaux 2010-03-04 13:36:04 UTC
Created attachment 41322 [details]
A screenshot showing the problem
Comment 2 mickael.chazaux 2010-03-04 13:38:40 UTC
Still present in 4.4.1. With default font settings (size 9), it is OK, but with size 11, the button starts to disappear.
Comment 3 Iker salmón 2010-05-08 01:09:00 UTC
Created attachment 43358 [details]
snapshot spanish translation
Comment 4 Iker salmón 2010-05-08 01:12:25 UTC
(In reply to comment #3)
> Created an attachment (id=43358) [details]
> snapshot spanish translation

The same issue with spanish translation, happenning in kde 4.4.3 debian package.

The description made in the first report matches perfectly with spansish translation issue
Comment 5 Julius-Caesar 2010-05-08 14:39:38 UTC
I have same problem, this is my system:

- Debian Sid, KDE 4.4.3, spanish localization.

Only setting the localization to english and fonts size to the default of
9 pixels can see it correctly.
Comment 6 Iker salmón 2010-05-10 20:50:22 UTC
if have noticed that the problem does not appear only with some translations.

I think that the position of the button, depends not only on the size of the plasmoid, because when the plasmoid is smaller than the lengh of the text of the mainlabel, the button is alligned right and bellow  the last letter of the text

This also happens even when it's in english  with  low resolutions and/or too big font sizes.  I've been reading the code of the plasmoid trying to underestand it in order to learn how to make some changes to make the button appear always inside the plasmoid  no matter how long the length of the text in the "m_mainlabel" is, however  i am a newbie in this matters.  The only thing i found is this:

"category->setAlignment(Qt::AlignRight);"

 by the way why AlignRight? if you see the https://bugs.kde.org/attachment.cgi?id=43358  i think that the label  with the description of the device "Volumen de almacenamiento" aligned right is not the best option.

cheers!
Comment 7 Jacopo De Simoi 2010-05-21 18:43:13 UTC
SVN commit 1129215 by jacopods:

Minimum sizes are evil, evil, evil!
BUG:226710


 M  +2 -1      notifierdialog.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1129215
Comment 8 Jacopo De Simoi 2010-05-21 18:43:54 UTC
SVN commit 1129216 by jacopods:

Backport r1129215
CCBUG:226710


 M  +2 -1      notifierdialog.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1129216
Comment 9 Jacopo De Simoi 2010-05-26 18:25:50 UTC
SVN commit 1130858 by jacopods:

Better fix, this actually works.
CCBUG:226710


 M  +2 -2      notifierdialog.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1130858
Comment 10 Jacopo De Simoi 2010-05-26 18:28:56 UTC
SVN commit 1130862 by jacopods:

Cleaner fix 
CCBUG:226710


 M  +1 -2      notifierdialog.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1130862