Bug 226668 - Allow disabling of Oxygen window decoration animations
Summary: Allow disabling of Oxygen window decoration animations
Status: RESOLVED FIXED
Alias: None
Product: Oxygen
Classification: Plasma
Component: win deco (show other bugs)
Version: unspecified
Platform: openSUSE Linux
: NOR wishlist
Target Milestone: ---
Assignee: Hugo Pereira Da Costa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-13 12:59 UTC by Lim Yuen Hoe
Modified: 2010-07-07 06:12 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Lim Yuen Hoe 2010-02-13 12:59:48 UTC
Version:            (using KDE 4.4.0)
OS:                Linux
Installed from:    openSUSE RPMs

Oxygen's new window decoration animations cannot be disabled except via the hacky method described here:

http://forum.kde.org/viewtopic.php?f=111&t=85571#p146475

The new animations can be performance-costly and can cause lag/choppiness in other kwin effects. So a clear option should be added in the standard systemsettings to allow users with lower machine specs to easily disable the animations should it affect them.
Comment 1 Martin Flöser 2010-02-13 13:22:45 UTC
Reassigning to Oxygen windeco component.

This is an important issue and we should consider asking i18n team to backport this config option.
Comment 2 Hugo Pereira Da Costa 2010-02-13 15:08:42 UTC
comments #1 and #2
I agree. An option has been added in kde-trunk in the decoration config window.
I'll try contact the translations people to see if it can be backported (to kde4.4.1)
Should not be too mich of a big deal since the added string ("Enable Animations") can be found elsewhere in the code (notably in oxygen style configuration)
Comment 3 Hugo Pereira Da Costa 2010-02-14 22:59:16 UTC
SVN commit 1090208 by hpereiradacosta:

Use KGlobalSettings::graphicEffectsLevel in conjunction with OxygenConfiguration to 
determine if animations should be enabled.

This allows to turn off all animations if the "graphical effects" combobox in
"systemsettings->appearance->style->fine tunning" is set to either
- Low display resolution and low CPU
- High display resolution and low CPU

BUG: 226668


 M  +1 -1      oxygenclient.cpp  
 M  +16 -4     oxygenclient.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1090208
Comment 4 Hugo Pereira Da Costa 2010-02-14 23:03:54 UTC
SVN commit 1090210 by hpereiradacosta:

Backport: r1090208

Use KGlobalSettings::graphicEffectsLevel in conjunction with
OxygenConfiguration to 
determine if animations should be enabled.

This allows to turn off all animations if the "graphical effects" combobox in
"systemsettings->appearance->style->fine tunning" is set to either
- Low display resolution and low CPU
- High display resolution and low CPU

CCBUG: 226668



 M  +1 -1      oxygenbutton.cpp  
 M  +1 -1      oxygenclient.cpp  
 M  +16 -4     oxygenclient.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1090210
Comment 5 Hugo Pereira Da Costa 2010-02-14 23:04:30 UTC
Feel free to re-open the bug if you don't find the above solution satisfactory
Comment 6 Martin Flöser 2010-02-14 23:34:41 UTC
(In reply to comment #5)
> Feel free to re-open the bug if you don't find the above solution satisfactory
Given that some complains were about very performant and modern GPUs, I think it is not a satisfying solution. But I have it on my list for Tokamak anyway
Comment 7 Hugo Pereira Da Costa 2010-02-15 00:02:59 UTC
Hi Martin, 

I actually am really confused by what's happening here. My laptop is tagged 'low resolution and high CPU' (its a DELL latitude 4300, Dual Core and Intel graphics card) and have none of the issues mentioned in this bug report. There must be some driver version involved, and possibly X ... 

The change above is the quick way to not add a string in the UI. But if people are ok with adding an (already existing) string, I can make the relevant change to oxygen config in a snap. (it's in trunk) 

(oh and I would have loved to discuss it with you directly on IRC, but from the paranoid place I'm here these days I have no access to IRC :-(, untill next tuesday)
Comment 8 Hugo Pereira Da Costa 2010-03-08 01:44:32 UTC
SVN commit 1100596 by hpereiradacosta:

Backport r1088959
Added checkbox to enable/disable decoration animations
CCMAIL: kde-i18n-doc@kde.org
CCBUG: 226634 
CCBUG: 226668


 M  +2 -0      config.cpp  
 M  +1 -0      oxygenconfigurationui.cpp  
 M  +8 -1      oxygenconfigurationui.ui  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1100596
Comment 9 Hugo Pereira Da Costa 2010-03-25 04:11:22 UTC
Commit corresponding to #8 should close this bug. Feel free to reopen (after kde4.4.2 is out) if necessary.
Comment 10 Francisco Villalobos 2010-05-22 17:51:02 UTC
I been having the slow effects problem since KDE 4.4, but disabling The Oxygen window decoration animations all works fine for me.
Comment 11 Hugo Pereira Da Costa 2010-05-22 18:43:05 UTC
@Francisco
As a side comment, for kde4.5, you might want to give oxygen animations another try. One of the possible reason for the slowdown might be the number of pixmaps stored in a cache to (initially at least), make stuff smoother. Turns out some GC are not happy about that. The cache size has been reduced a lot since then, which might fix the issue upstream. Keep me posted
Comment 12 Francisco Villalobos 2010-07-07 06:12:05 UTC
Now with KDE 4.4.5 the effects are more smooth, however, i have to disable the oxygen stile effects and modify the file: /home/belhor/.kde4/share/config/oxygenrc to have the best result

I'm using a Intel 945GM video card (a.k.a. GMA 950 27A2)