Bug 225925 - 'Edit categories' dialogue should not have an 'Apply' button
Summary: 'Edit categories' dialogue should not have an 'Apply' button
Status: VERIFIED FIXED
Alias: None
Product: kontact
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-08 16:56 UTC by Sabine Faure
Modified: 2010-02-19 16:35 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sabine Faure 2010-02-08 16:56:05 UTC
Version:            (using Devel)
Compiler:          gcc 4.3.2 
OS:                Linux
Installed from:    Compiled sources

- Launch Kontact and go to KOrg
- Click on 'New Event' button
- Click on 'Select...' button to select a category
- Click on the 'Edit Categories...' button and an 'Edit Categories - Kontact' dialogue appears.
- Click on the 'Add' button and enter a new category name (ex: Testing)
- Click on the 'Apply' button
- The 'Edit Categories - Kontact' dialogue remains there and to close it to check the Testing check box, you have to either click on 'Ok' or 'Cancel'.

This does not make sense to have an 'Apply button' here since the dialogue needs to be closed after the category is created. I think there just should be an 'Ok' and a 'Cancel' button.

The same dialogue can be called from Settings menu/Manage Categories... but it keeps the focus until it is closed too so there is no point in having an 'Apply' button there either. 

Trunk, Svn Rev  1086926
Comment 1 Laurent Montel 2010-02-09 20:08:43 UTC
SVN commit 1087905 by mlaurent:

Fix bug #225925
CCBUG: 225925


 M  +2 -2      categoryeditdialog.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1087905
Comment 2 Sabine Faure 2010-02-19 16:35:59 UTC
It is corrected now.

The 'Apply' button has been replaced by an 'Ok' button.

Trunk, Svn Rev 1092481