Bug 225857 - KonsolePart does not call cd with existing shell in TerminalInterface::showShellInDir()
Summary: KonsolePart does not call cd with existing shell in TerminalInterface::showSh...
Status: RESOLVED FIXED
Alias: None
Product: konsole
Classification: Applications
Component: kpart (show other bugs)
Version: unspecified
Platform: Compiled Sources Unspecified
: NOR normal
Target Milestone: ---
Assignee: Konsole Developer
URL:
Keywords:
: 234703 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-02-07 20:25 UTC by Friedrich W. H. Kossebau
Modified: 2011-11-19 21:59 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Friedrich W. H. Kossebau 2010-02-07 20:25:07 UTC 
Version:            (using Devel)
Installed from:    Compiled sources

virtual void TerminalInterface::showShellInDir( const QString& dir )* is defined as:
    "If a shell is currently shown, this sends it a cd command. 
    Otherwise, this starts a shell, and sends it a cd command too..."

While the second part works in KonsolePart as defined, the first one doesn't, no cd command is sent. This seems also the reason why the Kate Konsole plugin manually uses some
    sendInput("cd " + KShell::quoteArg(url.path()) + '\n');


* http://api.kde.org/4.x-api/kdelibs-apidocs/interfaces/html/classTerminalInterface.html#a976517f6ea1330bdd3b34ba0accc2b8a
Comment 1 denk 2011-04-04 21:36:17 UTC 
Anything new on this?

Due to this the embedded terminal in Kile spams bash history.
FYI: https://bugs.kde.org/show_bug.cgi?id=265165

Regards
denk
Comment 2 denk 2011-04-04 22:04:51 UTC 
Anything new on this?

Due to this the embedded terminal in Kile spams bash history.
FYI: https://bugs.kde.org/show_bug.cgi?id=265165

Regards
denk
Comment 3 Jekyll Wu 2011-07-06 07:45:38 UTC 
Is there any plan to fix this inconsistency between interface and implementation?
Comment 4 Jekyll Wu 2011-08-16 02:59:11 UTC 
*** Bug 234703 has been marked as a duplicate of this bug. ***
Comment 5 Kurt Hindenburg 2011-11-19 21:59:30 UTC 
Git commit 9b1014c92f96b5391c2173ca58f33821f1ce7216 by Kurt Hindenburg.
Committed on 19/11/2011 at 22:56.
Pushed by hindenburg into branch 'KDE/4.7'.

Correct API docs about TerminalInterface::showShellInDir().

If a shell is already running, nothing is done.  Otherwise, a new shell
is started in the @parm directory.
BUG: 225857

M  +3    -3    interfaces/terminal/kde_terminal_interface.h

http://commits.kde.org/kdelibs/9b1014c92f96b5391c2173ca58f33821f1ce7216