Bug 225854 - KonsolePart shows "Close Tab" in context menu
Summary: KonsolePart shows "Close Tab" in context menu
Status: RESOLVED FIXED
Alias: None
Product: konsole
Classification: Applications
Component: kpart (show other bugs)
Version: unspecified
Platform: Compiled Sources Unspecified
: NOR minor
Target Milestone: ---
Assignee: Konsole Developer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-07 20:10 UTC by Friedrich W. H. Kossebau
Modified: 2013-03-02 21:20 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.11


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Friedrich W. H. Kossebau 2010-02-07 20:10:31 UTC
Version:            (using Devel)
Installed from:    Compiled sources

Seems to be the same for Kate, KDevelop and Okteta (trunk). But they all only embed one KonsolePart, so that action is not valid (and not wanted by Okteta and KDevelop, which automatically reload the KPart if it disappears).
Comment 1 Jekyll Wu 2011-11-24 04:43:41 UTC
I agree "Close Tab" is a little misleading, because what it actually does is "Close Session". That difference is more important and better observed in the standalone Konsole, especially when split view is in use.

But I am not sure it is a good idea to remove that action from the context menu of Konsole Kpart. It provides a common way to close the Konsole Kpart. As for the automatic reloading in Okteka and Kdevelop, I do not know whether that is an intentional behavior, but I personally see it as bug instead of feature.

Just my 2 cents.
Comment 2 Jekyll Wu 2012-03-02 01:59:01 UTC
https://git.reviewboard.kde.org/r/103743/
Comment 3 Kurt Hindenburg 2013-03-02 21:20:47 UTC
Git commit 702f61953b26e978973cc5f626bbc58d74bcb7f0 by Kurt Hindenburg.
Committed on 02/03/2013 at 22:17.
Pushed by hindenburg into branch 'master'.

For KonsolePart use 'Close Session' as menu text

Having 'Close Tab' in konsole part is not really correct as there is
no tab.
FIXED-IN: 4.11

M  +5    -1    src/SessionController.cpp

http://commits.kde.org/konsole/702f61953b26e978973cc5f626bbc58d74bcb7f0