Version: (using KDE 4.3.4) OS: Linux Installed from: openSUSE RPMs Setting the scrollback option to unlimited history size and saving the output into file, the file is little corrupted, i.e. there is an additional empty line every 500 lines. Example: -------------------------------------------------------- user@pc:~> for i in {1..1002}; do echo $i; done; 1 2 [...] 498 499 [<--here] 500 501 [...] 998 999 [<--and here again] 1000 1001 1002 user@pc:~> --------------------------------------------------------
Yep, I see the same output.
SessionController.cpp const int LINES_PER_REQUEST = 500; // if there are still more lines to process after this request // then insert a new line character // to ensure that the next block of lines begins on a new line // // FIXME - There is still an extra new-line at the end of the save data. if ( copyUpToLine <= sessionLines-1 ) { stream << '\n'; }
(In reply to comment #2) > I do not quite understand that piece of code and comment. I tried to compile konsole without that piece of code, and did not notice problems in saved history .
Git commit 031a9d54e238c3372ee181b7bf7d290a320ea61d by Jekyll Wu. Committed on 24/07/2011 at 06:06. Pushed by jekyllwu into branch 'master'. Do not insert one extra emtpy line every 500 lines in the saved history. The code for adding that extra empty line was introduced in commit d3d909 (4 years ago). The reason and intention is not clear, so removing those code might cause regression. Anyway, this commit is simple and can be reverted easily, if unfortunately needed. BUG: 225501 FIXED-IN: 4.8 REVIEW: 102652 M +0 -11 src/SessionController.cpp http://commits.kde.org/konsole/031a9d54e238c3372ee181b7bf7d290a320ea61d