Bug 225347 - Curves from equations are not shown
Summary: Curves from equations are not shown
Status: RESOLVED FIXED
Alias: None
Product: kst
Classification: Applications
Component: general (show other bugs)
Version: 2.0.0
Platform: unspecified Microsoft Windows
: HI normal
Target Milestone: 2.0.0
Assignee: kst
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-03 08:29 UTC by Nicolas Brisset
Modified: 2010-11-12 10:42 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolas Brisset 2010-02-03 08:29:00 UTC
Version:           2.0.0_devel (using unspecified)
Compiler:          mingw delivered with QtCreator 1.1.0
OS:                Windows 32-Bit

There seems to be a problem with curves created from equations. To reproduce:

1) plot Column 1 vs INDEX from gyrodata.dat
2) create equation [Column 1 (V2)]+2 and add in new plot
3) result: the new plot is empty, while the data vectors have been created correctly and the second curve as well, as seen from the data manager! Of course, it is expected that the curve be shown.

Note that this is currently bothering us pretty badly. We'd be grateful if it could be fixed quickly, especially as it is a recent regression and probably relatively easy to fix.
Comment 1 Nicolas Brisset 2010-02-03 08:37:27 UTC
I have just checked and it seems histograms and power spectra suffer from the exact same problem. Hopefully a common cause...
I guess all plugins are impacted, which makes it pretty bad.
Comment 2 Nicolas Brisset 2010-02-03 16:22:54 UTC
I am pretty puzzled. I have just done a clean build under Linux, and there it seems to work fine. I'll try again to rebuild a complete Windows version, but yesterday I already did it.
Really strange!
Is anyone else on seeing this on any platform?
Comment 3 Matthew Truch 2010-02-03 16:28:27 UTC
I've been updating my machines here to svn trunk every morning and haven't seen this on Linux (checked only with PSDs which I use daily right now).
Comment 4 Nicolas Brisset 2010-02-03 17:47:44 UTC
So, under Windows I still have the problem after a complete new build. I'll try it with a different Qt version from home, but it looks like it's platform- or version-dependent. I don't know if that's good news...
Comment 5 Nicolas Brisset 2010-02-04 00:34:13 UTC
Unfortunately, on my home Windows machine with a different Qt version (4.6.1) and a debug build, I also have the problem. So it seems that there is a Windows-specific issue, but I really don't think it is linked with an unclean build. 
I suspect Matt is working under Linux exclusively.

Barth, how about you: can you test/debug that under Windows? Or Peter, are you still around?
Comment 6 Nicolas Brisset 2010-02-04 16:43:59 UTC
So, there we go: I have tracked down the problem to have appeared with revision 1054888 (the big update refactor). With revision 1051460 (the one just before) it works, and switching up just one revision (to 1054888), plus the patch from 1055898 needed to be able to use the data wizard with ASCII, it no longer works.
Now the question is: why only under Windows???
Comment 7 Grégoire Verlut 2010-02-05 04:46:22 UTC
On Windows PC, I also get the problem with the equation.  However when playing long enough with the curves using the equation vectors, I managed to see the curves but it disappeared when stored in a .kst file.

With the last revision (if I knew how to get the revision number), I also have some problems under linux.

With an english Ubuntu everything works almost fine, but with a german Ubuntu (from a colleague) the equation's editor does not understand float constant:
 "* 2.1" will be understood (and stored) as  "* 2"
meaning also that
 "/ 0.1" will be understood  as "/0"
When we tried with "1,4" instead of "1.4" the value remains in the equation, but no value is computed...
Comment 8 Peter Kümmel 2010-03-13 02:11:37 UTC
The UpdateManager doesn't resolve dependencies, and the update order 
seems to be different on the platforms.

In this case here the equation must first fill the vectors and update them
which then will be used by the curve.

Maybe there are other places with the same bug.
Comment 9 Netterfield 2010-03-24 03:04:22 UTC
SVN commit 1106882 by netterfield:

Found a serious bug in the update manager - previously, it only worked by
chance.... I'm really hoping that this will fix the windows update bug.
Can someone check?

CCBUG: 225347 

(also, fix a typo in data vector locking...)



 M  +1 -1      datavector.cpp  
 M  +2 -2      updatemanager.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1106882
Comment 10 Netterfield 2010-03-24 03:11:35 UTC
See devel_docs/Kst2Specs/Updates for a description of the update strategy (which might work now...)
Comment 11 Peter Kümmel 2010-03-27 12:06:21 UTC
On Windows I could remove the work around, so your patch works.
Comment 12 Nicolas Brisset 2010-04-26 08:40:25 UTC
I also confirm this seems to work OK now, so let's close it.
Comment 13 Peter Kümmel 2010-08-14 12:14:47 UTC
Change version from 2.0.0_devel to 2.0.0 to simplify version numbering.
Comment 14 Peter Kümmel 2010-11-12 10:42:28 UTC
These bugs are solved with 2.0.0