225339 – auto tab with auto switch animation

Bug 225339 - auto tab with auto switch animation

Summary: auto tab with auto switch animation

Status:	RESOLVED FIXED

Alias:	None

Product:	kwin
Classification:	Plasma
Component:	window-tabbing (show other bugs)
Version:	unspecified
Platform:	Compiled Sources Unspecified

Importance:	NOR normal
Target Milestone:	---
Assignee:	KWin default assignee

URL:
Keywords:

Depends on:
Blocks:

Reported:	2010-02-03 03:49 UTC by Alexandre Pereira
Modified:	2012-03-25 03:02 UTC (History)
CC List:	0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.

Description Alexandre Pereira 2010-02-03 03:49:37 UTC

Version:            (using Devel)
Installed from:    Compiled sources

hi

currently , with auto tab setting on , kwin does :

if auto switch to new window is on , when creating a new tabbed window, it will create the tab by also displaying the "create new window" animation.

if autoswitch to new window is off, when creating a new tabbed window it will do no animation, just create a new tab.

should it do animation in both cases , do no animation , or is this the correct behaviour ?

its a little weird to see the create new window animation , since it temporarily hides the already in screen window to show the animation

thanks

Comment 1 Thomas Lübking 2012-02-02 18:49:38 UTC

Sorry, but you're talking about stuff like scale or fade in, are you?

Comment 2 Thomas Lübking 2012-02-11 15:03:16 UTC

Git commit 94b2ad7b85801e37e2df4671cdc4f26b6d7e5506 by Thomas Lübking.
Committed on 12/01/2012 at 07:42.
Pushed by luebking into branch 'master'.

fix tabbing
Related: bug 290959, bug 265160, bug 229292, bug 238279, bug 290758, bug 222831, bug 278275, bug 245747, bug 230000, bug 253697, bug 230570, bug 265977, bug 225337

REVIEW: 103855

M  +1    -1    kwin/CMakeLists.txt
M  +2    -2    kwin/activation.cpp
M  +92   -51   kwin/bridge.cpp
M  +17   -11   kwin/bridge.h
M  +77   -47   kwin/client.cpp
M  +21   -12   kwin/client.h
D  +0    -357  kwin/clientgroup.cpp
D  +0    -266  kwin/clientgroup.h
M  +0    -1    kwin/clients/CMakeLists.txt
M  +2    -2    kwin/clients/aurorae/src/aurorae.cpp
M  +51   -62   kwin/clients/oxygen/oxygenclient.cpp
M  +4    -4    kwin/clients/oxygen/oxygenclient.h
M  +3    -3    kwin/clients/oxygen/oxygenclientgroupitemdata.cpp
M  +1    -1    kwin/clients/oxygen/oxygenclientgroupitemdata.h
M  +1    -1    kwin/clients/oxygen/oxygenfactory.cpp
D  +0    -15   kwin/clients/tabstrip/CMakeLists.txt
D  +0    -10   kwin/clients/tabstrip/config/CMakeLists.txt
D  +0    -96   kwin/clients/tabstrip/config/tabstripconfig.cpp
D  +0    -56   kwin/clients/tabstrip/config/tabstripconfig.h
D  +0    -78   kwin/clients/tabstrip/config/tabstripconfig.ui
D  +0    -63   kwin/clients/tabstrip/tabstrip.desktop
D  +0    -317  kwin/clients/tabstrip/tabstripbutton.cpp
D  +0    -55   kwin/clients/tabstrip/tabstripbutton.h
D  +0    -443  kwin/clients/tabstrip/tabstripdecoration.cpp
D  +0    -60   kwin/clients/tabstrip/tabstripdecoration.h
D  +0    -113  kwin/clients/tabstrip/tabstripfactory.cpp
D  +0    -63   kwin/clients/tabstrip/tabstripfactory.h
M  +12   -10   kwin/effects.cpp
M  +3    -3    kwin/effects.h
M  +1    -1    kwin/effects/boxswitch/boxswitch.cpp
M  +4    -4    kwin/effects/desktopgrid/desktopgrid.cpp
M  +2    -2    kwin/effects/flipswitch/flipswitch.cpp
M  +3    -3    kwin/effects/highlightwindow/highlightwindow.cpp
M  +3    -3    kwin/effects/presentwindows/presentwindows.cpp
M  +1    -1    kwin/effects/slideback/slideback.cpp
M  +3    -3    kwin/events.cpp
M  +15   -15   kwin/geometry.cpp
M  +19   -14   kwin/kcmkwin/kwindecoration/preview.cpp
M  +12   -11   kwin/kcmkwin/kwindecoration/preview.h
M  +3    -3    kwin/kwinbindings.cpp
M  +4    -4    kwin/layers.cpp
M  +27   -22   kwin/libkdecorations/kcommondecoration.cpp
M  +13   -11   kwin/libkdecorations/kcommondecoration.h
M  +31   -24   kwin/libkdecorations/kdecoration.cpp
M  +45   -52   kwin/libkdecorations/kdecoration.h
M  +15   -11   kwin/libkdecorations/kdecorationbridge.h
M  +1    -1    kwin/libkwineffects/kwineffects.cpp
M  +5    -5    kwin/libkwineffects/kwineffects.h
M  +92   -25   kwin/manage.cpp
M  +5    -5    kwin/options.cpp
M  +2    -2    kwin/options.h
M  +2    -2    kwin/scene.cpp
M  +1    -1    kwin/scene.h
M  +1    -16   kwin/scripting/meta.cpp
M  +0    -11   kwin/scripting/meta.h
M  +0    -4    kwin/scripting/workspace_wrapper.cpp
M  +0    -4    kwin/scripting/workspace_wrapper.h
M  +11   -13   kwin/sm.cpp
M  +2    -2    kwin/sm.h
A  +295  -0    kwin/tabgroup.cpp     [License: GPL (v2)]
A  +186  -0    kwin/tabgroup.h     [License: GPL (v2)]
M  +4    -0    kwin/toplevel.cpp
M  +122  -166  kwin/useractions.cpp
M  +8    -90   kwin/workspace.cpp
M  +13   -31   kwin/workspace.h

http://commits.kde.org/kde-workspace/94b2ad7b85801e37e2df4671cdc4f26b6d7e5506

Comment 3 Thomas Lübking 2012-02-11 15:31:03 UTC

Git commit 206257d750ca75e9b666acfc1413781614ab9a2d by Thomas Lübking.
Committed on 12/01/2012 at 07:42.
Pushed by luebking into branch 'master'.

fix tabbing
Related: bug 290959, bug 265160, bug 229292, bug 238279, bug 290758, bug 222831, bug 278275, bug 245747, bug 230000, bug 253697, bug 230570, bug 265977, bug 225337

REVIEW: 103855

M  +1    -1    kwin/CMakeLists.txt
M  +2    -2    kwin/activation.cpp
M  +92   -51   kwin/bridge.cpp
M  +17   -11   kwin/bridge.h
M  +77   -47   kwin/client.cpp
M  +21   -12   kwin/client.h
D  +0    -357  kwin/clientgroup.cpp
D  +0    -266  kwin/clientgroup.h
M  +0    -1    kwin/clients/CMakeLists.txt
M  +2    -2    kwin/clients/aurorae/src/aurorae.cpp
M  +51   -62   kwin/clients/oxygen/oxygenclient.cpp
M  +4    -4    kwin/clients/oxygen/oxygenclient.h
M  +3    -3    kwin/clients/oxygen/oxygenclientgroupitemdata.cpp
M  +1    -1    kwin/clients/oxygen/oxygenclientgroupitemdata.h
M  +1    -1    kwin/clients/oxygen/oxygenfactory.cpp
D  +0    -15   kwin/clients/tabstrip/CMakeLists.txt
D  +0    -10   kwin/clients/tabstrip/config/CMakeLists.txt
D  +0    -96   kwin/clients/tabstrip/config/tabstripconfig.cpp
D  +0    -56   kwin/clients/tabstrip/config/tabstripconfig.h
D  +0    -78   kwin/clients/tabstrip/config/tabstripconfig.ui
D  +0    -63   kwin/clients/tabstrip/tabstrip.desktop
D  +0    -317  kwin/clients/tabstrip/tabstripbutton.cpp
D  +0    -55   kwin/clients/tabstrip/tabstripbutton.h
D  +0    -443  kwin/clients/tabstrip/tabstripdecoration.cpp
D  +0    -60   kwin/clients/tabstrip/tabstripdecoration.h
D  +0    -113  kwin/clients/tabstrip/tabstripfactory.cpp
D  +0    -63   kwin/clients/tabstrip/tabstripfactory.h
M  +12   -10   kwin/effects.cpp
M  +3    -3    kwin/effects.h
M  +1    -1    kwin/effects/boxswitch/boxswitch.cpp
M  +4    -4    kwin/effects/desktopgrid/desktopgrid.cpp
M  +2    -2    kwin/effects/flipswitch/flipswitch.cpp
M  +3    -3    kwin/effects/highlightwindow/highlightwindow.cpp
M  +3    -3    kwin/effects/presentwindows/presentwindows.cpp
M  +1    -1    kwin/effects/slideback/slideback.cpp
M  +3    -3    kwin/events.cpp
M  +15   -15   kwin/geometry.cpp
M  +19   -14   kwin/kcmkwin/kwindecoration/preview.cpp
M  +12   -11   kwin/kcmkwin/kwindecoration/preview.h
M  +3    -3    kwin/kwinbindings.cpp
M  +4    -4    kwin/layers.cpp
M  +27   -22   kwin/libkdecorations/kcommondecoration.cpp
M  +13   -11   kwin/libkdecorations/kcommondecoration.h
M  +31   -24   kwin/libkdecorations/kdecoration.cpp
M  +45   -52   kwin/libkdecorations/kdecoration.h
M  +15   -11   kwin/libkdecorations/kdecorationbridge.h
M  +1    -1    kwin/libkwineffects/kwineffects.cpp
M  +5    -5    kwin/libkwineffects/kwineffects.h
M  +92   -25   kwin/manage.cpp
M  +5    -5    kwin/options.cpp
M  +2    -2    kwin/options.h
M  +2    -2    kwin/scene.cpp
M  +1    -1    kwin/scene.h
M  +1    -16   kwin/scripting/meta.cpp
M  +0    -11   kwin/scripting/meta.h
M  +0    -4    kwin/scripting/workspace_wrapper.cpp
M  +0    -4    kwin/scripting/workspace_wrapper.h
M  +11   -13   kwin/sm.cpp
M  +2    -2    kwin/sm.h
A  +295  -0    kwin/tabgroup.cpp     [License: GPL (v2)]
A  +186  -0    kwin/tabgroup.h     [License: GPL (v2)]
M  +4    -0    kwin/toplevel.cpp
M  +122  -166  kwin/useractions.cpp
M  +8    -90   kwin/workspace.cpp
M  +13   -31   kwin/workspace.h

http://commits.kde.org/kde-workspace/206257d750ca75e9b666acfc1413781614ab9a2d

Comment 4 Alexandre Pereira 2012-03-24 23:32:45 UTC

sorry, yes.

maybe a new kind of animation for windows in tabs ?

creating a new window in a tab would fire a "new window in tab" and not a normal "new window" animation.

what do you think ?

Comment 5 Thomas Lübking 2012-03-24 23:41:58 UTC

That would make a feature request.

4.9 will also allow for scripted animations, sou you can write a script to intercept tab additions and perform an animation - or write you an effect.
The bug described here should however be gone (in 4.9)

Comment 6 Alexandre Pereira 2012-03-25 03:02:37 UTC

thanks :)