Bug 224636 - some characters are encoded wrong when dropping a URL onto rekonq
Summary: some characters are encoded wrong when dropping a URL onto rekonq
Status: RESOLVED FIXED
Alias: None
Product: rekonq
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Andrea Diamantini
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-28 17:03 UTC by thomas gahr
Modified: 2010-02-05 14:55 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
possible fix: convert url to ascii before converting it with .toEncoded() EDIT: nevermind, breaks punycode of course... (866 bytes, patch)
2010-01-28 23:09 UTC, thomas gahr
Details

Note You need to log in before you can comment on or make changes to this bug.
Description thomas gahr 2010-01-28 17:03:49 UTC
Version:           0.3.33 (using 4.3.95 (KDE 4.3.95 (KDE 4.4 RC2)), 4.3.95-1.fc12 Fedora)
Compiler:          gcc
OS:                Linux (i686) release 2.6.31.12-174.2.3.fc12.i686

when dropping the following url (from konqueror) onto rekonq:
http://eigen.tuxfamily.org/index.php?title=ChangeLog
the "?" gets converted to "%3"
also, whitespace is not stripped from a url, so when pasting a url with a space character at its end, a "%20" is appended after pressing enter - just enter "www.google.com " to reproduce this.
i'm using rekonq from git
Comment 1 thomas gahr 2010-01-28 23:09:54 UTC
Created attachment 40327 [details]
possible fix: convert url to ascii before converting it with .toEncoded()

EDIT: nevermind, breaks punycode of course...

not sure if this completely defeats the purpose of .toEncoded()...
Comment 2 Panagiotis Papadopoulos 2010-02-05 14:55:20 UTC
Fixed: http://gitorious.org/rekonq/mainline/commit/821a246