Bug 224245 - Each image editor tool should remember the zoom ratio
Summary: Each image editor tool should remember the zoom ratio
Status: RESOLVED WORKSFORME
Alias: None
Product: digikam
Classification: Applications
Component: ImageEditor-Canvas (show other bugs)
Version: 1.1.0
Platform: unspecified Unspecified
: NOR wishlist
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-25 22:56 UTC by Julien Narboux
Modified: 2018-02-05 12:21 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 1.6.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Narboux 2010-01-25 22:56:21 UTC
Version:            (using KDE 4.3.4)

For some filters (sharpening, noise reduction) one will often want to preview at 100%. Thanks to Gilles, it is now possible with 1.1.0 !
I think it would be even better if each plugin could save the zoom ratio, so that next time you open a plugin you get the same zoom ratio as the last time the plugin was used.
By the way, in my opinion, some plugins should have a default of 100%: sharpening, noise reduction and maybe inpainting and restoration.

Julien
Comment 1 caulier.gilles 2010-01-25 23:13:15 UTC
I'm not really favorable for that. this will increase complexity...

Look the new behavior, ask with another bugzilla entry : the zoom ratio used in editor canvas must be the passed to editor tool preview.

Gilles Caulier
Comment 2 caulier.gilles 2010-01-26 06:26:22 UTC
I will be more precise here :

- zoom is synchronized.
- pan position is synchronized.

... when user go in editor tool and go out editor tool. this is fully transparent for end user : it think thank same widget is used to render image.

Gilles Caulier
Comment 3 Johannes Wienke 2010-01-26 23:28:36 UTC
I would also argue that all tools separated from the main view need a different zoom and pan position. I normally view images in "fit to screen" mode for doing global editing like cropping or color changes whereas sharpening or noise reduction needs to be done on zoomed versions and it's really annoying that you always have to do the same canonical "5 times press +" when entering the sharpening tool.
Comment 4 caulier.gilles 2010-01-28 09:29:14 UTC
Perhaps you have don't understand me :

- load an image to editor.
- zoom to a dedicated region. image still in canvas.
- load Refocus tool : region and zoom still used as well.
- change zoom level in tool, or pan image.
- apply Refocus and go back to canvas.
- Canvas use zoom and position set in Refocus.

I recommend to zoom/pan in image in canvas, select right region, and use tool. For me it's more intuitive and natural to force a zoom level for each tool.

Also, i like this behavior : canvas and editor tool preview are synchronized. This will be transparent for end user : canvas and preview sound like the same widget.

Gilles Caulier
Comment 5 Johannes Wienke 2010-01-28 10:39:41 UTC
But I don't want to zoom in first in the canvas only to zoom out again after having applied the filter.

I'd really vote at least for a user option.
Comment 6 Julien Narboux 2010-01-28 17:26:09 UTC
It would be nice to have other opinions about this. Andi, Marcel ? 

Julien
Comment 7 Wolfram Quester 2010-01-28 19:55:03 UTC
As a user, I think I'd like to have the same zoom ratios in all tools and canvas.
If I zoom in canvas and start a tool, the tool uses the adjusted zoom ratio. If I zoom in or out while using the tool, and exit the tool, the canvas should take the zoom level from the tool.
Comment 8 caulier.gilles 2010-01-29 08:30:02 UTC
Wolfram,

This is what i have implemented. It sound logic for me...

Other viewpoints ?

Gilles Caulier
Comment 9 Jens Mueller 2010-01-29 09:01:39 UTC
For me it is also more natural when canvas and tools act transparent to each other in case of zoom and view area, so current svn behaviour is fine for me ...

Jens
Comment 10 caulier.gilles 2010-03-03 16:12:27 UTC
I'm agree with Jens, and it's what i have implemented by default.

I'm not favorable to add another option in setup, only for this behavior.

I would to hear more viewpoints here. Marcel ?

Gilles Caulier
Comment 11 caulier.gilles 2010-10-22 13:35:24 UTC
Following reports here, I will let's the current zoom behavior between editor canvas and editor tools.

Gilles Caulier