Bug 224081 - Konsole tab bar should use tab widget corner buttons facility rather than a custom layout
Summary: Konsole tab bar should use tab widget corner buttons facility rather than a c...
Status: RESOLVED FIXED
Alias: None
Product: konsole
Classification: Applications
Component: tabbar (show other bugs)
Version: 2.4
Platform: Fedora RPMs Linux
: NOR minor
Target Milestone: ---
Assignee: Konsole Developer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-24 21:09 UTC by Eike Hein
Modified: 2019-07-16 13:25 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eike Hein 2010-01-24 21:09:15 UTC
Konsole currently realizes its tab bar corner buttons via a horizontal layout that has a button, then a tab bar and then another button as children. This makes it impossible for the Oxygen KStyle to extend the tab bar baseline along the buttons, as it does for tab bars which have corner buttons realized by way of the standard tab bar corner widget facility. This creates a visual inconsistency between Konsole and apps like Konqueror and Konversation.
Comment 1 Robert Knight 2010-01-25 16:43:17 UTC
The 'standard' corner widgets are part of QTabWidget not QTabBar unfortunately - which means that to get them you have to have the whole central area managed by QTabWidget.  If I remember correctly, Konsole does not use QTabWidget (it does use QTabBar though) because I wanted more control over the layout of the tabs and the margins and spacing around the main terminal - mainly to reduce them.  At the time QTabBar::documentMode() did not exist which solves some of the problems.

I also orignally had the idea that I might want to try other navigation methods than tabs (such as a vertical list of session names).

> This creates a visual inconsistency between Konsole
> and apps like Konqueror and Konversation.

This is true but only when the buttons are visible, which they are not by default because I wanted minimal visual clutter around the terminal area.
Comment 2 Eike Hein 2010-01-25 17:04:43 UTC
Using a regular tab bar in document mode should actually reduce the spacing further these days, e.g. the tab bar baseline is actually a pixel or two narrower then, for example (which would be another item on the list of visual inconsistencies right now).

The "baseline thing is only relevant when buttons are enabled" point is true, but then it's a pretty popular option for users to enable, and "but it's only buggy if the user uses the feature" isn't that much of an argument imho ;).

I understand the historic reasons for the difference, but whether it can be dealt with now would be worth investigating imho.
Comment 3 Robert Knight 2010-01-25 19:33:16 UTC
> I understand the historic reasons for the difference,
> but whether it can be dealt with now would be worth investigating imho.

Sure - I'd be happy to test a suitable patch.
Comment 4 tcanabrava 2019-06-25 08:31:20 UTC
Fix: Konsole now uses QTabWidget and does not rely in custom code for tabs.
Comment 5 Christoph Feck 2019-07-16 13:25:22 UTC
Tomaz, could you please set your full name in bugzilla? Our users have a right to know who fixes bugs :)