Bug 223863 - Date Navigator view does not update after changing the default holiday color.
Summary: Date Navigator view does not update after changing the default holiday color.
Status: VERIFIED FIXED
Alias: None
Product: korganizer
Classification: Applications
Component: general (show other bugs)
Version: 4.3
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-22 23:28 UTC by Sabine Faure
Modified: 2010-03-24 22:53 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sabine Faure 2010-01-22 23:28:44 UTC
Version:            (using Devel)
Compiler:          gcc 4.3.2 
OS:                Linux
Installed from:    Compiled sources

- Launch KOrg
- Go to Settings menu/Configure KOrganizer...
- Click on the Colors and Fonts Icon on the left hand side 
- Modify the default set color for 'Holiday color:' by clicking on its colored button, select a different color either from the palette or from the list of colors in the 'Select Color' window
- click on 'Ok'.
- Now click on the Time and Date icon on the left hand side of the 'Configure – KOrganizer' window. 
- In the Regional tab there is an 'Holidays' section and under it a 'Use holiday region:' combo box. Select your country in this combo box.
- Click on 'Ok'

Nothing happens in the date navigator view (the default color is not changed).

- Now click in one of the month view of the date navigator view.

The color is now changed from the default one to the one you picked for all the Saturdays and Sundays as well as for all the national holidays of your country.

Trunk, Svn Rev 1078580
Comment 1 Laurent Montel 2010-01-28 12:06:27 UTC
Here it works fine.
Reopen it if it doesn't work for you.
Thanks
Comment 2 Sabine Faure 2010-01-28 20:10:16 UTC
Yes it works as explained in the description above but only after clicking in the date navigator view. If you do not click in it after changing the display color of the weekends and national holidays then nothing is changed.

I am not sure that it is logical to wait for the user to realize that he has to click in the month view for it to update to the new color.

Trunk, Svn Rev 1081463
Comment 3 Laurent Montel 2010-01-29 10:44:17 UTC
Ok I see the problem.
Comment 4 Laurent Montel 2010-03-21 00:37:03 UTC
SVN commit 1105700 by mlaurent:

Fix bug #223863
CCBUG: 223863


 M  +1 -1      kdatenavigator.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1105700
Comment 5 Laurent Montel 2010-03-21 00:37:25 UTC
Fixed #1105700.
Comment 6 Sabine Faure 2010-03-24 22:53:22 UTC
It is corrected now.

When the holiday color is changed the new color is displayed as soon as the user clicks on the 'ok' button to close the 'Configure - KOrganizer' dialogue.

Trunk, Svn Rev 1106990