Bug 223684 - Timezone displayed in Digital Clock plasma widget is Kentucky
Summary: Timezone displayed in Digital Clock plasma widget is Kentucky
Status: RESOLVED FIXED
Alias: None
Product: plasma4
Classification: Unmaintained
Component: general (show other bugs)
Version: unspecified
Platform: FreeBSD Ports FreeBSD
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-21 15:37 UTC by Steven Friedrich
Modified: 2010-01-24 14:26 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Steven Friedrich 2010-01-21 15:37:39 UTC
Version:            (using KDE 4.3.4)
OS:                FreeBSD
Installed from:    FreeBSD Ports

My timezone is America/Kentucky/Louisville, but only Kentucky is displayed.
The true timezone is Eastern Standard Time, but adjusted for Daylight Savings
Time, as Eastern Daylight Time. EST and EDT, as appropriate, would be most
treasured.

I sent an email to Riccardo Iaconelli <riccardo@kde.org>.
His response was:
Unfortunately I can't do much on this one. That string is what kded
gives us as timezone name, and in theory it should be a user
comprehensible string.
Comment 1 Steven Friedrich 2010-01-21 16:10:14 UTC
As an initial improvement, I would rather it return the last part of America/Kentucky/Louisville, i.e., Louisville, rather than the middle component, Kentucky.

But it really should, depending on the time of year, display either EST or EDT.
Comment 2 Riccardo Iaconelli 2010-01-21 19:39:31 UTC
actually i just noted was wrong.
the relevant code is in clock.cpp, a call to prettyTimezone().
I somehow assumed that this was going directly to KTimezone, but while debugging some code I noticed that it's actually a method in libplasmaclock. The culprit can be found here: http://websvn.kde.org/trunk/KDE/kdebase/workspace/libs/plasmaclock/clockapplet.cpp?view=markup
line 163

I already have a patch, but will ask on plasma-devel for approval, since this changes behiavour that I don't know if was intended, and if so, what are the reasons for it.
Comment 3 Riccardo Iaconelli 2010-01-23 07:22:49 UTC
SVN commit 1078901 by ruphy:

Always return the most relevant part of the timezone.

I will probably backport it this CET afternoon if somebody doesn't beat me at it.

BUG: 223684

Signed-off-by: Riccardo Iaconelli <riccardo@kde.org>

 M  +1 -1      clockapplet.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1078901
Comment 4 Riccardo Iaconelli 2010-01-24 14:26:55 UTC
SVN commit 1079555 by ruphy:

Always return the most relevant part of the timezone.

CCBUG: 223684

Signed-off-by: Riccardo Iaconelli <riccardo@kde.org>

Backporting r1078901

 M  +1 -1      clockapplet.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1079555