Bug 221989 - KDoubleNumInput / KIntNumInput : minimum slider width are different and too big
Summary: KDoubleNumInput / KIntNumInput : minimum slider width are different and too big
Status: RESOLVED FIXED
Alias: None
Product: kdelibs
Classification: Frameworks and Libraries
Component: kdeui (show other bugs)
Version: SVN
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: kdelibs bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-10 00:38 UTC by DrSlony
Modified: 2018-08-28 10:48 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
screenshot (546.12 KB, image/png)
2010-01-24 02:29 UTC, DrSlony
Details
screenshot (544.60 KB, image/png)
2010-01-24 02:34 UTC, DrSlony
Details
screenshot (691.00 KB, image/png)
2010-01-24 02:36 UTC, DrSlony
Details
screenshot (765.01 KB, image/png)
2010-01-24 02:45 UTC, DrSlony
Details
screenshot (812.62 KB, image/png)
2010-01-24 02:46 UTC, DrSlony
Details
screenshot (757.98 KB, image/jpeg)
2010-01-24 02:54 UTC, DrSlony
Details
digiKam 1.4.0 raw editor panel 1 (493.26 KB, image/png)
2010-09-24 23:56 UTC, DrSlony
Details
digiKam 1.4.0 raw editor panel 2 (386.41 KB, image/png)
2010-09-24 23:56 UTC, DrSlony
Details
digiKam 1.4.0 color balance (411.02 KB, image/png)
2010-09-25 00:01 UTC, DrSlony
Details

Note You need to log in before you can comment on or make changes to this bug.
Description DrSlony 2010-01-10 00:38:19 UTC
Version:           1.0.0 (using KDE 4.3.4)
OS:                Linux
Installed from:    Gentoo Packages

It seems that there is a minimum slider width setting. If the width of the panel containing the slider is smaller than the minimal width, a horizontal scrollbar appears. This minimal width is too big. I can have large gaps between the slider's description and the end of the slider, meaning there is still lots of room to make the slider smaller, but I can't, because then the horizontal scrollbar appears instead of shrinking the slider. My resolution of 1440x900 is better than average, and still on this I feel limited.
e.g. the Enhance > Local Contrast panel and sliders, to avoid the horizontal scrollbar the whole panel has to be much wider than necessary.
Comment 1 caulier.gilles 2010-01-15 12:08:34 UTC
Which tool exactly ? Please attach a screenshot...

Gilles Caulier
Comment 2 DrSlony 2010-01-24 02:29:05 UTC
Created attachment 40174 [details]
screenshot
Comment 3 DrSlony 2010-01-24 02:34:29 UTC
Created attachment 40175 [details]
screenshot
Comment 4 DrSlony 2010-01-24 02:36:22 UTC
Created attachment 40176 [details]
screenshot
Comment 5 DrSlony 2010-01-24 02:45:14 UTC
Created attachment 40178 [details]
screenshot
Comment 6 DrSlony 2010-01-24 02:46:00 UTC
Created attachment 40179 [details]
screenshot
Comment 7 DrSlony 2010-01-24 02:54:26 UTC
Created attachment 40180 [details]
screenshot
Comment 8 Jens Mueller 2010-01-28 21:59:56 UTC
SVN commit 1081606 by jmueller:

allows the stages settings items from local contrast tool to have a smaller width
CCBUGS: 221989

 M  +4 -4      localcontrasttool.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1081606
Comment 9 caulier.gilles 2010-01-29 08:48:41 UTC
DrSlony,

Please checkout svn trunk and test if Jens commit fix your problem.

Thanks in advance

Gilles Caulier
Comment 10 Jens Mueller 2010-01-29 09:14:18 UTC
Commit http://websvn.kde.org/?view=rev&revision=1081612 is also relevant to this bug entry. But I think not all ui glitches are solved. As tool settings sidebar do not provide a pan area anymore (thanks Gilles, current pan area is at a better, common place now), the layout of tool settings sidebar changed at all. 

DrSlony, can you please evaluate tool settings sidebars with 1.1 again and provide screenshots as you do with 1.0?

Thanks in advance, Jens
Comment 11 DrSlony 2010-09-24 23:55:23 UTC
Sorry for the long delay, I haven't received notification of bug activity by email.

Looking at my old screenshots, the Local Optimize and Noise Reduction examples got fixed.
The raw processing panel hadn't.
Comment 12 DrSlony 2010-09-24 23:56:13 UTC
Created attachment 51967 [details]
digiKam 1.4.0 raw editor panel 1
Comment 13 DrSlony 2010-09-24 23:56:53 UTC
Created attachment 51968 [details]
digiKam 1.4.0 raw editor panel 2
Comment 14 DrSlony 2010-09-25 00:01:10 UTC
Created attachment 51969 [details]
digiKam 1.4.0 color balance
Comment 15 caulier.gilles 2010-09-25 09:04:24 UTC
DrSlony,

Thanks for your screenshots.

Sorry, but the different layout from slider setting widgets come from KDE Libs. In fact these slider come from differents API : KDoubleNumInput and KIntNumInput :

http://api.kde.org/4.x-api/kdelibs-apidocs/kdeui/html/classKDoubleNumInput.html

and 

http://api.kde.org/4.x-api/kdelibs-apidocs/kdeui/html/classKIntNumInput.html

Reimplemented in libkdcraw to set a default value button (as in Aperture) :

http://lxr.kde.org/source/KDE/kdegraphics/libs/libkdcraw/libkdcraw/rnuminput.h#42

and 

http://lxr.kde.org/source/KDE/kdegraphics/libs/libkdcraw/libkdcraw/rnuminput.h#83

We don't fix the layout from these widget directly in libkdcraw. It's defined internally in kdelibs. 

I reassign this bug to KDELIBs component.

Gilles Caulier
Comment 16 Christoph Feck 2010-09-30 05:13:21 UTC
The "wasted space" (too wide integer spin boxes) comes from a kdelibs bug incorrectly keeping the size when the widget was created (with maxval = INT_MAX). The next commit will fix this. Please check in digiKam if you set sane values for the range, otherwise the fix will not be visible.

The difference in slider lengths comes from the difference in sizes for the spin boxes (some are integer, some are floating point). If you want all of them to be the same size, you have to "chain" them using the constructors that have a "KNumInput *below" pointer. Note that these constructors are marked deprecated, but they should work nonetheless.
Comment 17 Christoph Feck 2010-09-30 05:19:04 UTC
SVN commit 1181110 by cfeck:

Fix sizeHint of KNumInput

If we don't re-read the column2width after doLayout(), then
we will keep the old size forever.

BUG: 221989


 M  +8 -6      knuminput.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1181110
Comment 18 Jens Mueller 2010-10-01 21:17:41 UTC
Christoph,

what about bugfix commit rules, is it possible to have to fix on 4.5 branch too? 

Thanks, Jens
Comment 19 Christoph Feck 2010-10-04 16:31:42 UTC
Jens, I didn't want to backport just at day of tagging. I will backport for 4.5.3.
Comment 20 Christoph Feck 2010-10-05 17:32:11 UTC
SVN commit 1182766 by cfeck:

Fix sizeHint of KNumInput (backport r1181110)

CCBUG: 221989


 M  +3 -1      knuminput.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1182766