Bug 221988 - "fit to window" and zooming out not working
Summary: "fit to window" and zooming out not working
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Showfoto-Canvas (show other bugs)
Version: 1.0.0
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-10 00:30 UTC by DrSlony
Modified: 2022-02-05 05:11 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 1.1.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description DrSlony 2010-01-10 00:30:37 UTC
Version:           1.0.0 (using KDE 4.3.4)
OS:                Linux
Installed from:    Gentoo Packages

In many panels the "fit to window" and "zoom out" options do not work. Without them, I can't judge a whole photo in portrait orientation, greatly discouraging me from trying to use whatever options in showfoto prevent me from fitting to window/zooming out.
Comment 1 caulier.gilles 2010-01-15 12:07:20 UTC
When it doesn't work ? When you use an tool like NR or refocus, or only with simple canvas mode ?

Gilles Caulier
Comment 2 caulier.gilles 2010-01-20 12:20:43 UTC
SVN commit 1077548 by cgilles:

Editor Tool Preview factoring : Important change here
- Now editor tool based on image region widget preview can be zommed to 100% all time. there is no zomming 
restriction based on image size to always fit contents to preview size.
- When user select a zommable editor tool, canvas zoom is applied to preview.
- All preview mode are available with image region widget tools based (NR, refocus, etc...)

Warnings: this commit do not finalize preview factoring and regressions tests need to be done again. 
I can see preview dysfunctions in some cases.

TODO : port progressively all editor tools based on image guide widget (not zommable) to image region widget (zommable) as WB, curves, levels, etc...

BUGS: 221987
BUGS: 163284
BUGS: 148072
BUGS: 222975
CCBUGS: 197316
CCBUGS: 148235
CCBUGS: 220567
CCBUGS: 196469
CCBUGS: 221988



 M  +5 -0      canvas/canvas.cpp  
 M  +1 -0      canvas/canvas.h  
 M  +7 -4      editor/editortooliface.cpp  
 M  +24 -54    widgets/imageregionwidget.cpp  
 M  +4 -7      widgets/imageregionwidget.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1077548
Comment 3 caulier.gilles 2010-01-21 17:39:53 UTC
SVN commit 1078142 by cgilles:

Zoom to 100% is now available with all editor tools based on imageregionwidget as refocus and NR.
CCBUGS: 221988
CCBUGS: 196469


 M  +4 -4      editorwindow.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1078142
Comment 4 caulier.gilles 2010-01-22 08:20:23 UTC
SVN commit 1078356 by cgilles:

Zoom to fit is now available with all editor tools based on imageregionwidget
as refocus and NR.
BUGS: 221988
BUGS: 196469


 M  +6 -0      libs/widgets/common/previewwidget.cpp  
 M  +1 -0      libs/widgets/common/previewwidget.h  
 M  +13 -10    utilities/imageeditor/editor/editorstackview.cpp  
 M  +3 -2      utilities/imageeditor/editor/editorstackview.h  
 M  +10 -3     utilities/imageeditor/editor/editortooliface.cpp  
 M  +4 -5      utilities/imageeditor/editor/editorwindow.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1078356
Comment 5 DrSlony 2010-01-24 01:49:57 UTC
Great! :)