Bug 221963 - The font size in which the contacts are displayed is to small
Summary: The font size in which the contacts are displayed is to small
Status: RESOLVED FIXED
Alias: None
Product: kaddressbook
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
: 285009 292998 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-01-09 20:03 UTC by Christian Trippe
Modified: 2012-06-29 12:46 UTC (History)
14 users (show)

See Also:
Latest Commit:
Version Fixed In: 4.8.4


Attachments
screenshot of kaddressbook (127.71 KB, image/png)
2010-01-09 20:04 UTC, Christian Trippe
Details
patch that remove "fontsize=-1" (707 bytes, patch)
2012-05-15 21:50 UTC, Cor Blom
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Trippe 2010-01-09 20:03:35 UTC
Version:           4.4 rc1 (using 4.3.90 (KDE 4.3.90 (KDE 4.4 RC1)) "release 208", KDE:KDE4:Factory:Desktop / openSUSE_11.2)
Compiler:          gcc
OS:                Linux (i686) release 2.6.31.8-0.1-default

The font size in which the data of a contact is displayed is much to small in my opinion.

Please compare the used font size for the data with the other fonts/texts in the attach screenshot. It is much smaller than all other texts.
Comment 1 Christian Trippe 2010-01-09 20:04:22 UTC
Created attachment 39717 [details]
screenshot of kaddressbook
Comment 2 Tristan Miller 2010-03-05 13:11:30 UTC
Confirming bug still exists in KDE 4.4.1.
Comment 3 Janet 2010-03-31 14:08:19 UTC
The font size for the information pane should be configurable by the user. For some people it is important to have a lot information in one row and they accept a tiny font size to achieve this, for others the layout is less important, for them it's more important that they can *read* the information...
Comment 4 Christian Reiner 2010-07-14 09:58:22 UTC
This issue still exists in KDE-4.4.5.
Comment 5 Andreas Hölscher 2011-06-26 07:12:32 UTC
This issue still exists in KDE-4.6.4
Comment 6 S. Burmeister 2011-06-26 09:03:04 UTC
kdepim 4.6 does not obey any font settings as it seems as well, i.e. changing "small font" in KDE's systemsettings does not change the font size in kaddressbook. If this is hard-coded it should at least be changed to use the "small fonts" setting.

Better would be of course if the user could set which setting to use, i.e. either "normal font" or "small font".

Doing fon settings per app does not make sense imho, but using KDE's different settings and not hardcoding some size is crucial.
Comment 7 Anders Lund 2012-02-01 20:43:34 UTC
It looks from the sight, as the contact view is using the small font from the kde font settings, but it obviously should use the normal size.
Comment 8 Jonathan Marten 2012-02-27 13:43:18 UTC
*** Bug 292998 has been marked as a duplicate of this bug. ***
Comment 9 Christian (Fuchs) 2012-04-13 15:31:44 UTC
The problem is not in kaddressbook but rather in standardcontactformatter.cpp from kde pimlibs  (akonadi/contact/standardcontactformatter.cpp)  lines 62 and 63: 

62        "<td align=\"right\" valign=\"top\" width=\"30%\"><b><font size=\"-1\" color=\"grey\">%1</font></b></td>\n"
63    "<td align=\"left\" valign=\"top\" width=\"70%\"><font size=\"-1\">%2</font></td>\n"


as we can see here, the font size is set to "-1" for whatever reason. 

I patched it locally, and now I have nice big fonts. As this is a rather generic component, I have no idea whether it's a bad idea to change it there. It might break things in other places. 

So dear developers, please 

1) change this to respect user settings or at least global KDE settings if it doesn't break things or
2) use something else in kaddressbook to have the fonts at an acceptable size there. 

Thank you very much :)
Comment 10 Cor Blom 2012-05-15 21:50:50 UTC
Created attachment 71119 [details]
patch that remove "fontsize=-1"

FYI: This patch is added to kdepimlibs4 in openSUSE. It will be part of the coming 12.2 release. Based on comment 9.
Comment 11 Allen Winter 2012-05-20 21:58:30 UTC
Git commit 9360eadef4001130891e747e3c07689d241560ed by Allen Winter.
Committed on 20/05/2012 at 22:23.
Pushed by winterz into branch 'master'.

remove "size = -1" from font size html element.
should help the tiny font size complaints.
FIXED-IN: 4.8.4
MERGE: 4.8

M  +2    -2    akonadi/contact/standardcontactformatter.cpp
M  +5    -5    akonadi/contact/standardcontactgroupformatter.cpp

http://commits.kde.org/kdepimlibs/9360eadef4001130891e747e3c07689d241560ed
Comment 12 Allen Winter 2012-05-20 21:59:11 UTC
Git commit cc541d8a8fa056489ee56671d807aac469419594 by Allen Winter.
Committed on 20/05/2012 at 22:23.
Pushed by winterz into branch 'KDE/4.8'.

remove "size = -1" from font size html element.
should help the tiny font size complaints.
FIXED-IN: 4.8.4
MERGE: 4.8
(cherry picked from commit 9360eadef4001130891e747e3c07689d241560ed)

M  +2    -2    akonadi/contact/standardcontactformatter.cpp
M  +5    -5    akonadi/contact/standardcontactgroupformatter.cpp

http://commits.kde.org/kdepimlibs/cc541d8a8fa056489ee56671d807aac469419594
Comment 13 Jonathan Marten 2012-05-24 11:04:49 UTC
*** Bug 285009 has been marked as a duplicate of this bug. ***
Comment 14 Christian (Fuchs) 2012-06-28 18:24:04 UTC
And this bug is back with 4.9 Beta / RC, since it got moved to 

kaddressbook/viewertemplates/contact_row.html
kaddressbook/viewertemplates/contactgroup_memberrow.html
kaddressbook/viewertemplates/contactgroup_additionalfieldrow.html

Please fix this before 4.9 final is out, the font is definitely not readable for most settings with a font size of -1, which you are setting there. 

Thanks, kind regards

Christian
Comment 15 Laurent Montel 2012-06-29 07:15:17 UTC
It's false it works fine
and viewertemplates is used just when we use grandlee and we can't use grandlee in kaddressbook...

Ok will remove font size -1 in theses files if a day we uses grandlee but this bug is closes and fixed before this patch.
Comment 16 Laurent Montel 2012-06-29 07:16:34 UTC
Git commit 9bb05459b02e6175365cbc1d7357da6b2f2f27e3 by Montel Laurent.
Committed on 29/06/2012 at 09:15.
Pushed by mlaurent into branch 'master'.

Remove font size=-1 when we use grandlee but we don't use grandlee

Perhaps in the future we will use it.

M  +2    -2    kaddressbook/viewertemplates/contact_row.html
M  +2    -2    kaddressbook/viewertemplates/contactgroup_additionalfieldrow.html
M  +2    -2    kaddressbook/viewertemplates/contactgroup_memberrow.html

http://commits.kde.org/kdepim/9bb05459b02e6175365cbc1d7357da6b2f2f27e3
Comment 17 Laurent Montel 2012-06-29 07:17:38 UTC
Git commit ec5add174490dd9738d0d99e7efa02397de0e6e5 by Montel Laurent.
Committed on 29/06/2012 at 09:15.
Pushed by mlaurent into branch 'KDE/4.9'.

Remove font size=-1 when we use grandlee but we don't use grandlee

Perhaps in the future we will use it.
(cherry picked from commit 9bb05459b02e6175365cbc1d7357da6b2f2f27e3)

M  +2    -2    kaddressbook/viewertemplates/contact_row.html
M  +2    -2    kaddressbook/viewertemplates/contactgroup_additionalfieldrow.html
M  +2    -2    kaddressbook/viewertemplates/contactgroup_memberrow.html

http://commits.kde.org/kdepim/ec5add174490dd9738d0d99e7efa02397de0e6e5
Comment 18 Christian (Fuchs) 2012-06-29 12:46:06 UTC
Thanks for the information, then I have to check with gentoo "packagers". 
Because when I build current 4.9 RC 1  without changes, the fonts are too small.  When I change the mentioned files (I assume one of them would be sufficient, but I'll have to check which one) and rebuild, the fonts are fine. 

This is a bit strange, since gentoo usually just builds the tarballs as provided, but it should be rather easy to find out what's going wrong here, then. 

Thanks for the fix, kind regards