Bug 221794 - Amarok won't copy flac or wma files to external device.
Summary: Amarok won't copy flac or wma files to external device.
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Applications
Component: Collections/Media Devices (show other bugs)
Version: 2.3-GIT
Platform: Compiled Sources Unspecified
: NOR normal
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords:
: 222402 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-01-08 14:14 UTC by thomas coopman
Modified: 2013-01-13 01:16 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
add wma to the list of allowed format when copying to a UMS device. (911 bytes, patch)
2010-01-24 10:44 UTC, thomas coopman
Details

Note You need to log in before you can comment on or make changes to this bug.
Description thomas coopman 2010-01-08 14:14:42 UTC
Version:            (using Devel)
Installed from:    Compiled sources

When I try to copy a flac album to an external collection it won't work.  Amarok says the files are already on the device (while this is not the case.)
Copying mp3 files does work (as do ogg files).
The exact error message from amarok is this: Tracks not copied: the device already has these tracks.

I just tried copying wma files and that failed too.

The devices I tried copying to are a external hard disk and a sansa clip+

This is on a recent git version from amarok.
Comment 1 Mikko C. 2010-01-08 15:45:53 UTC
I thought we had a report about this already but I can't find it atm.
Comment 2 Myriam Schweingruber 2010-01-12 17:22:22 UTC
*** Bug 222402 has been marked as a duplicate of this bug. ***
Comment 3 Cyril Brosch 2010-01-19 16:03:54 UTC
I can confirm with Amarok 2.2.1 and 2.2.2 (Mandriva 2010.0 with KDE 4.3), also with a Sansa Clip+, but it doesn't work with a simple USB flash drive, too.

I can't copy ogg-files, though, only mp3s (I don't have flac-files to try).
Comment 4 Mikko C. 2010-01-24 09:59:03 UTC
should be fixed in upcoming 2.2.3

commit 5ea7c2fc47f88c82b79f8680da6775deee398326
Author: Nikolaj Hald Nielsen <nhn@kde.org>
Date:   Wed Jan 20 12:36:46 2010 +0100

    Add flac and ogg to the list of allowed format when copying to a UMS device.

    This stuff needs a real config dialog, but this change at least makes amarok usefull with the my N900.
    Also TODO: the error message when tracks cannot be copied, for any reason, always defaults to "tracks are already on device" even if the reason is another one, such as the format not being supported by the device.
    Ideally it should show a dialog with the failure reason for wach track that is not copied, and it seems the basis of this is already in the code, just not used yet.
    ~lart xevix
Comment 5 Cyril Brosch 2010-01-24 10:02:13 UTC
Thanks a lot for the fix!

Is .wma added to allowed files, too?
Comment 6 thomas coopman 2010-01-24 10:44:31 UTC
Created attachment 40186 [details]
add wma to the list of allowed format when copying to a UMS device.
Comment 7 thomas coopman 2010-01-24 10:46:14 UTC
The patch I submitted should add wma to the list of allowed files.
Comment 8 Myriam Schweingruber 2010-01-24 10:56:07 UTC
Thomas, thank you for the patch, but please make a merge request on http://gitorious.org/amarok/amarok so the developers can have a look at.
Comment 9 thomas coopman 2010-01-24 11:18:39 UTC
(In reply to comment #8)
> Thomas, thank you for the patch, but please make a merge request on
> http://gitorious.org/amarok/amarok so the developers can have a look at.

Ok, I'll look into it.
Comment 10 Mark Kretschmann 2010-01-26 08:33:27 UTC
I've just merged this into mainline (thanks Thomas!):


commit 93e2ccc98da4c1295bde5cc0c5809e0c62dfde34
Author:     Thomas Coopman <thomas.coopman@gmail.com>
AuthorDate: Sun Jan 24 11:28:25 2010 +0100
Commit:     Thomas Coopman <thomas.coopman@gmail.com>
CommitDate: Sun Jan 24 11:28:25 2010 +0100

   Add wma to the list of allowed format when copying to a UMS device.

diff --git a/src/collection/umscollection/handler/UmsHandler.cpp b/src/collection/umscollection/handler/UmsHandler.cpp
index 3c5c471..5c038e7 100644
--- a/src/collection/umscollection/handler/UmsHandler.cpp
+++ b/src/collection/umscollection/handler/UmsHandler.cpp
@@ -894,7 +894,7 @@ UmsHandler::supportedFormats()
 {
    QStringList formats;

-    formats << "mp3" << "aac" << "mp4" << "m4a" << "m4b" << "flac" << "ogg";
+    formats << "mp3" << "aac" << "mp4" << "m4a" << "m4b" << "flac" << "ogg" << "wma";

    return formats;
 }
Comment 11 Discrete Chan 2013-01-12 12:43:43 UTC
I use Amarok 2.6.0 on Archlinux and this hasn't be fixed! I cannot transfer flac files to my Sony NWZ-B152F.
Comment 12 Myriam Schweingruber 2013-01-13 01:16:04 UTC
(In reply to comment #11)
> I use Amarok 2.6.0 on Archlinux and this hasn't be fixed! I cannot transfer
> flac files to my Sony NWZ-B152F.

Please open a new bug, it makes no sense to comment on a bug long closed as there has been too much code change since.
I presume that the device you mention does actually support playing flac and wma files, else the transfer wouldn't make much sense. Since we don't have all possible media devices at our discretion, please be more specific in your report about the specifications of the device you are using, e.g. connection type, hardward specs, supported codecs and id3 version.