Bug 221687 - Maximize plot (Z) has become awfully slow
Summary: Maximize plot (Z) has become awfully slow
Status: RESOLVED FIXED
Alias: None
Product: kst
Classification: Applications
Component: general (show other bugs)
Version: 2.0.0
Platform: unspecified Microsoft Windows
: NOR normal
Target Milestone: 2.0.0
Assignee: kst
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-07 18:00 UTC by Nicolas Brisset
Modified: 2010-11-12 10:42 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolas Brisset 2010-01-07 18:00:03 UTC
Version:           2.0.0_devel (using unspecified)
Compiler:          mingw delivered with QtCreator 1.1.0
OS:                Windows 32-Bit

I don't know what happened, but I suspect one of the recently committed changes broke something with the consequence that hitting "Z" on a plot to maximize it takes seconds to react, while it used to be very fast (and needs to be very fast).
It feels as if the complete session (or at least window) were being reloaded...
Comment 1 Netterfield 2010-01-12 22:48:36 UTC
SVN commit 1073794 by netterfield:

don't redraw plots/curve that are masked by maximizing another plot.
BUG: 221687



 M  +3 -1      libkst/vector.cpp  
 M  +0 -1      libkstapp/cartesianrenderitem.cpp  
 M  +6 -2      libkstapp/plotitem.cpp  
 M  +2 -1      libkstapp/plotitem.h  
 M  +5 -0      libkstapp/plotrenderitem.cpp  
 M  +2 -1      libkstapp/view.cpp  
 M  +4 -0      libkstapp/view.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1073794
Comment 2 Nicolas Brisset 2010-01-14 15:44:35 UTC
Sorry Barth, but there must be something else. 
I have just done a fresh compile (under Windows) and it still exhibits the same slow behavior.

Maybe there was more than one issue? Or you haven't committed the complete fix?
Comment 3 Nicolas Brisset 2010-01-14 15:59:46 UTC
I have just tested on a (much) faster computer, and I don't notice the lag there. On the slower computer, loading the test file takes a good 10 seconds until I see the plots. Maximizing one plot is not far from taking as much time, while I mean it used to be much faster (though now that I'm wondering, I can't really be sure). Anyways, I mean it *should* be faster, even it wasn't before :-)
Comment 4 Netterfield 2010-01-19 02:17:58 UTC
Please specify 
-OS & hardware
-Test details:
  number of plots
  number of samples
  data source type

-timing results

If possible, please include complementary test results from kst1.x
Comment 5 Netterfield 2010-02-01 21:30:16 UTC
This bug was reopened, but with no specifics, which makes it hard to fix or close.  Please specify....
Comment 6 Nicolas Brisset 2010-02-02 09:52:01 UTC
Yes, I know. I'm late, but I haven't come around to it lately. On my fast Linux machine I can compile very fast, which makes it ideal for testing, but I can hardly notice the problem.
On the slow Windows machine, compiling takes ages but the problem is obvious. 
I have to take some time to investigate that in more detail. I'll try to let the compilation run in the background while I do something else...
Comment 7 Nicolas Brisset 2010-04-29 11:11:08 UTC
So, with today's svn version and a completely fresh and clean build, this seems to be acceptable again. Maybe at some point I tested with an unclean build, it seems I have been bitten by that a number of times lately. Sorry for the noise...
I'll close this report now.
Comment 8 Peter Kümmel 2010-08-14 12:14:38 UTC
Change version from 2.0.0_devel to 2.0.0 to simplify version numbering.
Comment 9 Peter Kümmel 2010-11-12 10:42:22 UTC
These bugs are solved with 2.0.0