Bug 221571 - integrate rawtherapee into digikam
Summary: integrate rawtherapee into digikam
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Plugin-RawImport-Rawtherapee (show other bugs)
Version: 0.10.0
Platform: openSUSE Unspecified
: NOR wishlist
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-06 20:52 UTC by Johannes Tögel
Modified: 2022-01-26 04:17 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.4.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Johannes Tögel 2010-01-06 20:52:35 UTC
Version:           0.10.0 (using KDE 4.3.1)
Installed from:    openSUSE RPMs

On January 4th, 2010 version 3.0 alpha 1 of the well-known RAW editing and conversion program RawTherapee (http://www.rawtherapee.com) got released - with one very important change: RawTherapee is now Open Source (GPLv3)!

This (and the fact that RawTherapee is modular, e.g. the interface and the engine are seperate) mean that finally there is the opportunity to integrate one of the finest RAW processors available for Linux right into digikam - it would be great if this happened, because, in my opinon, handling RAW files is one of the few weak points of digikam at the moment.

RawTherapee has got many advantages over dcraw, for example faster RAW conversion, way better color reproduction (at least for me) etc.

I don't know much about the technical details (for example what should be implemented in dcraw instead of digikam), but I think a better RAW workflow would be very useful for a great number of users.
Comment 1 caulier.gilles 2010-01-07 08:48:39 UTC
This is not the right place for this report.

digiKam use libraw as RAW decoder (http://www.libraw.org)

If rawtherapee core must be integrated in digiKam, this must be done in libraw as well.

Please report to libraw team your wish... Thanks in advance

Gilles Caulier
Comment 2 Marcel Wiesweg 2010-01-07 19:15:50 UTC
Gilles, I dont think libraw is the right place to support rawtherapee's engine. libraw is still basically a library wrapper around dcraw. rawtherapee is using dcraw as well at the lowest level, for bit access, as does almost everyone, but around that is much more (http://www.rawtherapee.com/?mitem=4&faqid=17) -
RawTherapee is algorithms. As far as I know it's the first time that a new set of algorithms for RAWs (i.e., not written by Dave Coffin) is becoming available, new demosaicing algorithms and a whole stack for postprocessing. I'm a bit excited about that.
Comment 3 caulier.gilles 2010-01-07 23:16:00 UTC
Marcel,

I know RawTherapee. I think libraw ithe right place to integrate new demosaicing algorithm. libraw is alrady more than a simple library based on dcraw code.

I CC Alex Tutubalin for a real viewpoint there...

Gilles
Comment 4 Alex Tutubalin 2010-01-08 14:30:57 UTC
RawTherapee is very interesting project, but.... take look into LibRaw's long TODO list (http://www.libraw.org/about#todo).

The LibRaw's postprocessing stage (entirely derived from dcraw) is included into the library just because it is *free* (already included in dcraw and we're automatically make some LibRaw's sources from dcraw.c).

There is no plans to improve/change this postprocessing stage much *within* LibRaw project. LibRaw's goal is to provide RAW data accessible for raw converters/analyzers/etc developers without the exact knowlege about particular format, camera firmware version etc.

Yes, digiKam uses our postprocessing calls. But most of LibRaw users are not.

Another problem is RawTherapee licensing. It licensed under GPLv3. We've started with GPL3 two years ago, than switched to GPL2, than to LGPL2 (for LibRaw Lite). We're planning to switch to something Apache-style (only copyright notice in derived works) because GPL/LGPL licenses are really show-stoppers for many users.
So, no GPLv3 code in LibRaw, thanks.
Comment 5 caulier.gilles 2019-09-18 18:42:06 UTC
Git commit c1bda3cf95236ee918ca761c8ce82de982f81d4b by Gilles Caulier.
Committed on 18/09/2019 at 18:40.
Pushed by cgilles into branch 'master'.

RAW Import tool: new plugin to import RAW files using RawTherapee in Image Editor.
FIXED-IN: 6.4.0

M  +7    -3    NEWS
M  +2    -0    core/dplugins/rawimport/CMakeLists.txt
A  +23   -0    core/dplugins/rawimport/rawtherapee/CMakeLists.txt
A  +197  -0    core/dplugins/rawimport/rawtherapee/rawimportrawtherapeeplugin.cpp     [License: GPL (v2+)]
A  +85   -0    core/dplugins/rawimport/rawtherapee/rawimportrawtherapeeplugin.h     [License: GPL (v2+)]

https://invent.kde.org/kde/digikam/commit/c1bda3cf95236ee918ca761c8ce82de982f81d4b