Bug 221529 - Expanding a stack with first image a portrait doesn't work as it should
Summary: Expanding a stack with first image a portrait doesn't work as it should
Status: RESOLVED FIXED
Alias: None
Product: kphotoalbum
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: KPhotoAlbum Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-06 14:50 UTC by Aleksi Halkola
Modified: 2010-06-14 18:42 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Handles mouse/sensitive area for stacked pictures properly. (2.02 KB, patch)
2010-06-04 00:00 UTC, Andreas Neustifter
Details
Correctly calculate area for stack handles. (3.26 KB, patch)
2010-06-05 12:31 UTC, Andreas Neustifter
Details
Extremely reduced patch. (1.45 KB, patch)
2010-06-05 15:46 UTC, Andreas Neustifter
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Aleksi Halkola 2010-01-06 14:50:03 UTC
Version:           4.1.1 (using KDE 4.3.3)
Compiler:          gcc 4.3.4 
OS:                Linux
Installed from:    Gentoo Packages

If the first image of a stack is portrait clicking on the lower right corner of the image doesn't expand the stack. One needs to click on the position where the lower right corner of the image would be if it were landscape.
Comment 1 Hassan Ibraheem 2010-01-15 12:28:39 UTC
fixed in r1075019.
Basically many stack indicator dimensions were based on the image dimensions. It's now using the cell dimensions except for the first and last image in the stack.
Comment 2 Hassan Ibraheem 2010-01-15 12:49:52 UTC
I'm reopening the bug as I've misunderstood it.
The above fixes the stack indicator visually, the mouse action is still wrongly placed though.
Comment 3 Andreas Neustifter 2010-06-04 00:00:22 UTC
Created attachment 47650 [details]
Handles mouse/sensitive area for stacked pictures properly.

Please test.
Comment 4 Aleksi Halkola 2010-06-04 22:14:20 UTC
Thanks. I did some testing and this seems to work more or less
correctly now. The less part is that for landscape photos one can also
click on the lines indicating the stack, where as for portrait photos
one has to click to just off the lines. But now there's plenty of
space to click on.

Aleksi

On 4 June 2010 00:00, Andreas Neustifter <astifter@gmx.at> wrote:
> https://bugs.kde.org/show_bug.cgi?id=221529
>
>
>
>
>
> --- Comment #3 from Andreas Neustifter <astifter gmx at>  2010-06-04 00:00:22 ---
> Created an attachment (id=47650)
>  --> (http://bugs.kde.org/attachment.cgi?id=47650)
> Handles mouse/sensitive area for stacked pictures properly.
>
> Please test.
>
> --
> Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
> ------- You are receiving this mail because: -------
> You are on the CC list for the bug.
> You reported the bug.
>
Comment 5 Andreas Neustifter 2010-06-05 12:31:40 UTC
Created attachment 47693 [details]
Correctly calculate area for stack handles.

I have enlarged the area a notch so that rounding errors and such do not lead to inconsistent behaviour. I guess the area is now large enough and predictable enough to be useful.
Comment 6 Andreas Neustifter 2010-06-05 15:46:15 UTC
Created attachment 47703 [details]
Extremely reduced patch.

I knew there was an easier way to do this, this is a vastly simplyfied patch that does the same thing.
Comment 7 Jesper K. Pedersen 2010-06-14 18:42:34 UTC
SVN commit 1137916 by blackie:

BUG: 221529
Fixed the location of the stack indicator.

Thanks to Andreas Neustifter for the patch.


 M  +14 -3     ThumbnailWidget.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1137916