Bug 221490 - [Patch] MarbleWidget does not honour setEnabled(false)
Summary: [Patch] MarbleWidget does not honour setEnabled(false)
Status: RESOLVED FIXED
Alias: None
Product: marble
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: marble-bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-06 09:26 UTC by Michael
Modified: 2010-01-15 22:40 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
marble-enabled-disabled.diff (1.41 KB, patch)
2010-01-06 19:23 UTC, Dennis Nienhüser
Details
marble-enabled-disabled.png (231.93 KB, image/png)
2010-01-06 19:26 UTC, Dennis Nienhüser
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael 2010-01-06 09:26:46 UTC
Version:           1.0.0 (using 4.3.1 (KDE 4.3.1) "release 6", openSUSE 11.2)
Compiler:          gcc
OS:                Linux (x86_64) release 2.6.31.8-0.1-desktop

If some photos don't contain GPS data, nevertheless within the marble geolocalization window the (wrong/outdated) GPS data from the last photo containing GPS data is used within shown map.

Please deactivate map view for photos without GPS data (e.g. show a grey box or text like "No GPS data available").
Comment 1 caulier.gilles 2010-01-06 09:44:10 UTC
I know the problem. But marble widget do not switch view to disable if a set widget with this status. I suspect that marble widget disable state is not implemented.

In fact, all is already done in digiKAm to manage this condition : no GPS data => disable marble view.

I fork this entry to marble team.

Gilles Caulier
Comment 2 Dennis Nienhüser 2010-01-06 19:23:29 UTC
Created attachment 39620 [details]
marble-enabled-disabled.diff

When calling setEnabled(false) on MarbleWidget, disable input (keyboard and mouse) and paint everything overlayed with some gray color to indicate that the widget is disabled.
Comment 3 Dennis Nienhüser 2010-01-06 19:26:43 UTC
Created attachment 39621 [details]
marble-enabled-disabled.png

Screenshot showing the effect of the patch, setEnabled(true) above, setEnabled(false) below.
Comment 4 Dennis Nienhüser 2010-01-06 19:31:38 UTC
Another thing is missing: MarbleWidget::setInputEnabled(false) which is used by the patch currently ignores FloatItems, for example you can still double click on the overview map (float item in the top left) and have Marble jump to the specified location.
Comment 5 Dennis Nienhüser 2010-01-11 23:04:00 UTC
SVN commit 1073273 by nienhueser:

When the MarbleWidget is disabled, disable keyboard and mouse input and draw contents grayscaled.
CCBUG: 221490


 M  +35 -2     MarbleWidget.cpp  
 M  +6 -0      MarbleWidget.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1073273
Comment 6 Dennis Nienhüser 2010-01-11 23:07:15 UTC
Changed the patch to draw grayscale instead -- the composite version looked a bit too worn out. I'll backport this to branches/4.4 in time for RC2.
Comment 7 Dennis Nienhüser 2010-01-15 22:40:29 UTC
SVN commit 1075344 by nienhueser:

When the MarbleWidget is disabled, disable keyboard and mouse input and draw contents grayscaled.
Backport of commit 1073273.
BUG: 221490


 M  +35 -2     MarbleWidget.cpp  
 M  +6 -0      MarbleWidget.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1075344