Bug 220818 - inline rename always starts when clicking on a selected track
Summary: inline rename always starts when clicking on a selected track
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Applications
Component: Playlist (show other bugs)
Version: 2.6-git
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords:
: 220874 222079 227841 242481 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-12-31 16:22 UTC by Alexander Potashev
Modified: 2013-01-13 21:33 UTC (History)
9 users (show)

See Also:
Latest Commit: http://commits.kde.org/amarok/b608ae4d1787da64636e92060daae74bd5f3ebf1
Version Fixed In: 2.7
Sentry Crash Report:
myriam: Usability+

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Potashev 2009-12-31 16:22:24 UTC 
Version:           2.2-GIT (using 4.3.85 (KDE 4.3.85 (KDE 4.4 Beta2)), Gentoo)
Compiler:          x86_64-pc-linux-gnu-gcc
OS:                Linux (x86_64) release 2.6.32

1. Put an album with several songs into the playlist.
2. Click on the top of the album group in the playlist to select all the songs from that album (album grouping should be enabled for that).
3. Say, you now want to select a single song from that album (for example, in order to remove it from the playlist). You click on that song, but Amarok "offers" you to rename the song instead of selecting only that song. The whole album remains selected.

Desired behaviour: if there are multiple tracks selected in the playlist, clicking on one of them should reduce selection to only that track.
Comment 1 Myriam Schweingruber 2010-01-04 15:14:00 UTC 
Confirmed with current Amarok 2.2-git. Not a wish, but a bug. It is driving mad to have the inline editing popping up all the time just because I click on the same entry in the playlist a second time.
Comment 2 Mikko C. 2010-01-04 15:16:09 UTC 
*** Bug 220874 has been marked as a duplicate of this bug. ***
Comment 3 Javier Conti 2010-01-04 15:28:29 UTC 
I'd like to add that, as happens for some other programs already, if ctrl+a selects all, it would be nice if shift+ctrl+a selects none. I think that would be rather intuitive and consistent.
Comment 4 Myriam Schweingruber 2010-01-10 22:22:32 UTC 
*** Bug 222079 has been marked as a duplicate of this bug. ***
Comment 5 Myriam Schweingruber 2010-02-20 21:12:55 UTC 
*** Bug 227841 has been marked as a duplicate of this bug. ***
Comment 6 Thorsten Mühlfelder 2010-03-11 17:05:47 UTC 
And I'd like to add, that it would be great if the inline tag editing could be disabled by a menu option because I don't want my id3 tags to be edited accidently by me or someone else.
Comment 7 Samuel Brack 2010-12-07 23:16:24 UTC 
This bug is still existent in 2.4-GIT with the difference, that amarok wants you to edit the song's title, but the entire album isn't selected any more (opposing to the description in the original post).
Comment 8 Myriam Schweingruber 2012-11-29 11:57:57 UTC 
*** Bug 242481 has been marked as a duplicate of this bug. ***
Comment 9 Ralf Engels 2013-01-13 21:33:32 UTC 
Git commit b608ae4d1787da64636e92060daae74bd5f3ebf1 by Ralf Engels.
Committed on 13/01/2013 at 22:11.
Pushed by rengels into branch 'master'.

Fix inline rename always starts when clicking on a selected track

Qt calls the editor even if the selection just changed.
We remember the time of the last change and block the editor in that
case.
FIXED-IN: 2.7

M  +19   -1    src/playlist/view/listview/PrettyListView.cpp
M  +4    -0    src/playlist/view/listview/PrettyListView.h

http://commits.kde.org/amarok/b608ae4d1787da64636e92060daae74bd5f3ebf1