Bug 220766 - When knotes send via net, it doesn't support unicode and force everything convert to ascii. (with patch)
Summary: When knotes send via net, it doesn't support unicode and force everything con...
Status: RESOLVED FIXED
Alias: None
Product: knotes
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR wishlist
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-31 04:57 UTC by timchen119
Modified: 2010-01-16 23:34 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
knotes unicode patch (1.87 KB, patch)
2009-12-31 05:00 UTC, timchen119
Details

Note You need to log in before you can comment on or make changes to this bug.
Description timchen119 2009-12-31 04:57:24 UTC
Version:            (using Devel)
Compiler:          gcc version 4.4.2 (Gentoo 4.4.2 p1.0)  
OS:                Linux
Installed from:    Compiled sources


Problem:
When knotes send notes via network, it doesn't support unicode and force everything convert to ascii. 

Expect:
every unicode character (eg: CJKV characters) should be fine.

Solution:
A better solution is to convert our string to unicode via system locale, and convert back when received on another host. that makes we could get correct messages if two host have same locales.
Comment 1 timchen119 2009-12-31 05:00:15 UTC
Created attachment 39470 [details]
knotes unicode patch
Comment 2 Allen Winter 2010-01-09 20:24:43 UTC
SVN commit 1072266 by winterz:

timchen119's patch for supporting Unicode in notes.
thanks for the patch!
BUG:220766
MERGE: 4.4


 M  +4 -1      knotesnetrecv.cpp  
 M  +6 -6      knotesnetsend.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1072266
Comment 3 Allen Winter 2010-01-16 23:33:36 UTC
SVN commit 1075869 by winterz:

backport SVN commit 1072266 by winterz:

timchen119's patch for supporting Unicode in notes.
thanks for the patch!
CCBUG:220766


 M  +4 -1      knotesnetrecv.cpp  
 M  +6 -6      knotesnetsend.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1075869
Comment 4 Allen Winter 2010-01-16 23:34:15 UTC
SVN commit 1075870 by winterz:

backport SVN commit 1072266 by winterz:

timchen119's patch for supporting Unicode in notes.
thanks for the patch!
BUG:220766


 M  +4 -1      knotesnetrecv.cpp  
 M  +6 -6      knotesnetsend.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1075870