Bug 220444 - auto lens correction does not recognize a listed camera and lens using exif data
Summary: auto lens correction does not recognize a listed camera and lens using exif data
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Plugin-Editor-LensCorrection (show other bugs)
Version: 1.0.0
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-28 20:32 UTC by Manuel
Modified: 2016-07-01 09:22 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 1.1.0
Sentry Crash Report:


Attachments
Exif example (14.63 KB, application/octet-stream)
2009-12-28 20:34 UTC, Manuel
Details
Asci exif extracted bu exiv2 from a Canon 450D CR2 file (38.51 KB, text/plain)
2009-12-29 19:56 UTC, Manuel
Details
Asci exif extracted by exiv2 from a Canon 450D/XSi CR2 file, 18-55mm lens (38.68 KB, text/plain)
2009-12-29 20:46 UTC, Manuel
Details
An image example (71.54 KB, image/jpeg)
2009-12-29 22:00 UTC, Manuel
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel 2009-12-28 20:32:14 UTC
Version:            (using KDE 4.3.2)
OS:                Linux
Installed from:    Ubuntu Packages

My canon 450D camera kit is listed but not recognized when a lens auto correction is selected from digikam, lens tested: 18-55 IS camera kit + 50mm f/1.4 USM
Comment 1 Manuel 2009-12-28 20:34:43 UTC
Created attachment 39415 [details]
Exif example
Comment 2 caulier.gilles 2009-12-28 20:53:01 UTC
It's not a kipi-plugins but a digiKam image editor plugin. There is 2 plugin interface in digiKam

Gilles Caulier
Comment 3 caulier.gilles 2009-12-28 20:53:42 UTC
Which version of digiKam you use ?

Gilles Caulier
Comment 4 Dario Andres 2009-12-28 21:36:00 UTC
@Gilles: the reporter is using a disposable email address: you are not going to get feedback from him. If you indeed need more information to check this bug, the report should be closed :-\
Comment 5 Dario Andres 2009-12-29 01:15:35 UTC
Closing...
Comment 6 Manuel 2009-12-29 03:04:26 UTC
(In reply to comment #4)
> @Gilles: the reporter is using a disposable email address: you are not going to
> get feedback from him. If you indeed need more information to check this bug,
> the report should be closed :-\

@Dario Andres: Not a disposable email, this is the way a found to organize emails from different sites and let me shadow my real email
Comment 7 Dario Andres 2009-12-29 03:17:39 UTC
Nice to know then... Reopening the report.
- What is your Digikam version ?
Regards
Comment 8 Manuel 2009-12-29 03:22:52 UTC
(In reply to comment #3)
> Which version of digiKam you use ?
> 
> Gilles Caulier

digikam:
  Installed: 2:1.0.0~rc-1ubuntu1~karmic1
  Candidate: 2:1.0.0~rc-1ubuntu1~karmic1
  Version table:
 *** 2:1.0.0~rc-1ubuntu1~karmic1 0
        500 http://mirrors.us.kernel.org karmic-backports/main Packages
     2:1.0.0~beta5-1ubuntu1 0
        500 http://mirrors.us.kernel.org karmic/main Packages

kdelibs5:
  Installed: 4:4.3.2-0ubuntu7.2
  Candidate: 4:4.3.2-0ubuntu7.2
  Version table:
 *** 4:4.3.2-0ubuntu7.2 0
        500 http://mirrors.us.kernel.org karmic-security/main Packages
        500 http://mirrors.us.kernel.org karmic-updates/main Packages
     4:4.3.2-0ubuntu7 0
        500 http://mirrors.us.kernel.org karmic/main Packages

libkipi6:
  Installed: 4:4.3.2-0ubuntu1
  Candidate: 4:4.3.2-0ubuntu1
  Version table:
 *** 4:4.3.2-0ubuntu1 0
        500 http://mirrors.us.kernel.org karmic/main Packages

kipi-plugins:
  Installed: 0.9.0-1ubuntu1~karmic1
  Candidate: 0.9.0-1ubuntu1~karmic1
  Version table:
 *** 0.9.0-1ubuntu1~karmic1 0
        500 http://mirrors.us.kernel.org karmic-backports/main Packages
        100 /var/lib/dpkg/status
     0.7.0-1ubuntu2 0
        500 http://mirrors.us.kernel.org karmic/main Packages

Ubuntu 9.10

Linux laptop 2.6.31-17-generic #54-Ubuntu SMP 


Hope this help

Manuel
Comment 9 caulier.gilles 2009-12-29 09:26:33 UTC
Information taken from Exif to extract Lens info are processed by Exiv2 library. 

Yes, we use Exif to identify Lens...

Look code here :

http://lxr.kde.org/source/extragear/graphics/digikam/libs/dmetadata/dmetadata.cpp#941

But perhaŝ your model is not detected properly. Which Exiv2 version you use ?

Gilles Caulier
Comment 10 Manuel 2009-12-29 15:37:18 UTC
exiv2:
  Installed: 0.18.2-1
  Candidate: 0.18.2-1
  Version table:
 *** 0.18.2-1 0
        500 http://mirrors.us.kernel.org karmic/main Packages


Canon uses different names to the same product, my camera has 3: Canon EOS 450D / Digital Rebel XSi / Kiss X2 Digital
Comment 11 Manuel 2009-12-29 17:57:50 UTC
According to Exif information (well detected by the way) my camera is a

Model : Canon EOS DIGITAL REBEL XSi
Manufacturer : Canon

The lens auto correction has the equivalent model listed

CANON EOS 450D DIGITAL 

which is the same camera

The same problems but fixed is the previous model

CANON EOS 400D DIGITAL 
CANON EOS DIGITAL REBEL XT
Comment 12 caulier.gilles 2009-12-29 18:01:13 UTC
Can you give us an image sample to test ?

Gilles Caulier
Comment 13 Manuel 2009-12-29 18:46:55 UTC
The smallest possible size is 11.7MB (CR2.7z) or 12.3 CR2, is this OK
to upload to bugs.kde.org?
Comment 14 caulier.gilles 2009-12-29 18:54:09 UTC
Give us a link outside bugzilla. smallesst file size here is 1Mb

Gilles Caulier
Comment 15 Manuel 2009-12-29 19:56:12 UTC
Created attachment 39437 [details]
Asci exif extracted bu exiv2 from a Canon 450D CR2 file

Here is an asci plain exif file as

exiv2 -pt IMG_6229.CR2>IMG_6229.exv
Comment 16 Manuel 2009-12-29 20:09:40 UTC
(In reply to comment #9)
> Information taken from Exif to extract Lens info are processed by Exiv2
> library. 
> 
> Yes, we use Exif to identify Lens...
> 
> Look code here :
> 
> http://lxr.kde.org/source/extragear/graphics/digikam/libs/dmetadata/dmetadata.cpp#941
> 
> But perhaŝ your model is not detected properly. Which Exiv2 version you use ?
> 
> Gilles Caulier

Accoding to 
QString DMetadata::getLensDescription() const
...
     lensExifTags.append("Exif.CanonCs.Lens");        // Canon Cameras Makernote.
     lensExifTags.append("Exif.Canon.0x0095");        // Alternative Canon Cameras Makernote.
...

Digikam gets 
Exif.CanonCs.Lens                            Short       3  50.0 mm
Exif.Canon.0x0095                            Ascii      64  EF50mm f/1.4 USM

and omit

Exif.CanonCs.LensType                        Short       1  Canon EF 50mm f/1.4 USM

Which is more similar to editor plugin's lens list. I didn't rich the plugins source yet so I don't know if it use another field to match the list

This USM lens does not match exactly any in the list, I'll look for another example using camera kit

Later
Manuel
Comment 17 Manuel 2009-12-29 20:46:06 UTC
Created attachment 39438 [details]
Asci exif extracted by exiv2 from a Canon 450D/XSi CR2 file, 18-55mm lens
Comment 18 Manuel 2009-12-29 22:00:37 UTC
Created attachment 39439 [details]
An image example

Here is a jpg image, raw image is too large to post here
Comment 19 caulier.gilles 2009-12-29 23:18:45 UTC
yes, lens data are there. But are you sure that LensFun library know your camera model and your lens ? Because the tool use this library to perform lens corrections...

Gilles Caulier
Comment 20 Manuel 2009-12-30 17:22:29 UTC
2009/12/29 Gilles Caulier - :
> https://bugs.kde.org/show_bug.cgi?id=220444
>
>
>
>
>
> --- Comment #19 from Gilles Caulier <caulier gilles gmail com>  2009-12-29 23:18:45 ---
> yes, lens data are there. But are you sure that LensFun library know your
> camera model and your lens ? Because the tool use this library to perform lens
> corrections...
>
> Gilles Caulier
>
> --
> Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
> ------- You are receiving this mail because: -------
> You reported the bug.
>
>

You are right, LensFun does not has this camera registered, I did
spend some time before advert  digikam use LensFun. I've a custom
LensFun database which will post to this library as a patch but need
more time to make lens calibrations available

Later,
Manuel Soto
Comment 21 caulier.gilles 2009-12-30 17:42:54 UTC
Great to hear.

Please, if you know to make calibration files for lensfun, let's me hear. A lots of people want to contribute, but without a notice, it's difficult

Thanks in advance

Gilles Caulier
Comment 22 Manuel 2010-01-05 15:33:43 UTC
Hello Gilles Caulier

After upgrate to 1.0 final, digikam & kipi-plugins, available in Ubuntu back-ports, the camera is recognized very well. I'll work on lens
Comment 23 caulier.gilles 2010-01-05 18:39:20 UTC
Ok, can i close this file now ?

Gilles caulier
Comment 24 Manuel 2010-01-05 19:14:28 UTC
> --- Comment #23 from Gilles Caulier   2010-01-05 18:39:20 ---
> Ok, can i close this file now ?
>
> Gilles caulier
>

Yes, in case I solve lens calibration I'll send a patch to related plugin

Later
Manuel