Bug 219693 - can't move saved playlist to a newly created playlist folder
Summary: can't move saved playlist to a newly created playlist folder
Status: RESOLVED NOT A BUG
Alias: None
Product: amarok
Classification: Applications
Component: Playlists/Saved Playlists (show other bugs)
Version: 2.3-GIT
Platform: unspecified Linux
: NOR normal
Target Milestone: 2.3.0
Assignee: Amarok Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-22 16:27 UTC by Dmitry Suzdalev
Modified: 2010-05-10 08:38 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
screenshot (297.26 KB, image/png)
2009-12-22 16:27 UTC, Dmitry Suzdalev
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Suzdalev 2009-12-22 16:27:01 UTC
Version:           2.2-GIT (using 4.3.85 (KDE 4.3.85 (KDE 4.4 Beta2)), compiled sources)
Compiler:          gcc
OS:                Linux (i686) release 2.6.31-ARCH

Steps to reproduce:

1. Launch amarok and go to Playlists=>Saved playlists
2. Create folder "my folder"
3. Earlier I saved a certain live radio stream as a playlist to internal database.
4. I select respective item in saved playlists list and try to drag it on top of "my folder" to move it there
5. When I realease mouse - nothing happens => item is left where it was, no errors or something

Expected behavior:
Dragged list item gets moved to "my folder" folder

Screenshot is attached.

Version info:
Amarok: master, 734fbeddc26d98d0b5b1a78712a66ee7b02dbc7c
KDE: trunk, Revision: 1065063
Qt: 4.6.0, kde-qt/master
Comment 1 Dmitry Suzdalev 2009-12-22 16:27:34 UTC
Created attachment 39244 [details]
screenshot
Comment 2 Bart Cerneels 2009-12-23 12:46:32 UTC
I can't reproduce this. Does it work with any of the other playlists?
Comment 3 Dmitry Suzdalev 2009-12-23 13:19:49 UTC
oh, right. It works with usual playlists in my collection.

But it doesn't for a playlist with a saved stream. Here are the corrected steps to reproduce then:

1. Add this stream to playlist: http://www.di.fm/mp3/spacemusic.pls
2. Start playing it
3. At the bottom of playlist widget press and hold "Save" button, choose "save to disk"
4. Accept the default name it suggests for a playlist
5. Now try to drag it to "my folder" => nothing happens as described earlier
Comment 4 Bart Cerneels 2009-12-23 13:31:04 UTC
Ha, I see what the problem is now.
When saving "to disk" it's actually being saved as an XSPF-file in $KDEHOME/share/apps/amarok/playlists. But our implementation of XSPF does not support labels, which are needed to store what folder it's supposed to be saved in.

For some playlist-file types such as M3U and PLS it's impossible to save the label inside the file itself. But XSPF is XML and we should be able to add a new element for labels.

This will have to wait for the next version though as we are in feature freeze.

Use the database playlist type. It supports labels and is actually the preferred method of saving playlists since it's a lot faster and better tested.
Comment 5 Dmitry Suzdalev 2009-12-23 13:41:31 UTC
Great. Thanks for analysis and a workaround :)
Comment 6 Myriam Schweingruber 2009-12-23 15:21:37 UTC
Setting target.
Comment 7 Pierre Dumuid 2010-02-17 01:06:45 UTC
I'm actually having problems with database / non-stream tracks as well! I can make a folder, and can move 1 or 2 playlists into the folder, but after that, the operation seems to abort!  (Sometimes I can only drag a single playlist into a folder!)

Also,folder-in-a-folder doesn't work at all.
Comment 8 Soren Harward 2010-05-10 02:42:06 UTC
The playlist interface changed a lot between 2.2 and 2.3, so it looks like this bug is no longer valid.  There aren't even folders anymore.
Comment 9 Pierre Dumuid 2010-05-10 06:09:03 UTC
Umm, the interface hasn't changed that much since 2.2 and 2.3.  I've just re-compiled at 96205dd70d02369224bac075c3b70f422a9c60c7 (which is the lastest version of amarok from git as of today) and I can definitely see folders:

Media Sources -> Playlists -> Save Playlists files on disk

To the right of "Visible Sources" you can toggle between one-level grouped view according to "Playlist files on Disk,Internal Database" or a folder view.  And when in folder view, you can create folders, and drag playlists into them.

There's also a "Add folder" button that becomes enabled for use.  If "There aren't even folders anymore", why is there still an "Add Folder" button?

At the moment, I can only add folders one-level deep, but I'm thankfull I can still add folders.  I believe folders and sub-folders are instrumental in helping to organise playlists.  I'd find it very dissapointing if we remove the ability to have sub-folders!  I find it kinda crazy that amarok still hasn't got this back to par with amarok 1.4 usability in this area, and I wish I had the skills / time to fix this bug.

For a usage example of sub-folders: Consider a person involved in playing music for a number of events, it used to be possibly to organize folder say for "weddings", "parties" and sub-folders for the event name, and then sub-playlists organised by the time / type of music depending on the stage of the night / mood.  This was my typical usage for amarok 1.4, and had thought it would have been fairly similar for others.

I would very much appreciate if someone agreed with me and re-opened the bug..

Regards,

Pierre
Comment 10 Bart Cerneels 2010-05-10 08:38:21 UTC
(In reply to comment #9)
> I would very much appreciate if someone agreed with me and re-opened the bug..

It's not impossible nor unwanted, just low priority. Please create a new wish list item for this.